Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std: Remove old_io/old_path from the prelude #23470

Merged
merged 1 commit into from
Mar 21, 2015

Conversation

alexcrichton
Copy link
Member

This commit removes the reexports of old_io traits as well as old_path types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like Seek in the std::io
module (currently reexported as NewSeek in the io prelude).

Closes #23377
Closes #23378

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@bors
Copy link
Contributor

bors commented Mar 18, 2015

☔ The latest upstream changes (presumably #22838) made this pull request unmergeable. Please resolve the merge conflicts.

@aturon
Copy link
Member

aturon commented Mar 18, 2015

Delighted that this day has come!

r=me after a rebase

@alexcrichton
Copy link
Member Author

@bors: r=aturon

@bors
Copy link
Contributor

bors commented Mar 18, 2015

📌 Commit 47cb40d has been approved by aturon

@bors
Copy link
Contributor

bors commented Mar 19, 2015

⌛ Testing commit 47cb40d with merge e4e647e...

@bors
Copy link
Contributor

bors commented Mar 19, 2015

💔 Test failed - auto-win-32-opt

@alexcrichton
Copy link
Member Author

@bors: r=aturon e4e647e

@bors
Copy link
Contributor

bors commented Mar 19, 2015

🙀 e4e647e is not a valid commit SHA. Please try again with c3eb592.

@alexcrichton
Copy link
Member Author

@bors: r=aturon c3eb592

@bors
Copy link
Contributor

bors commented Mar 20, 2015

⌛ Testing commit c3eb592 with merge 52830ab...

@bors
Copy link
Contributor

bors commented Mar 20, 2015

💔 Test failed - auto-win-32-opt

@alexcrichton
Copy link
Member Author

@bors: r=aturon b962ec0

@bors
Copy link
Contributor

bors commented Mar 20, 2015

⌛ Testing commit b962ec0 with merge d5c590a...

@bors
Copy link
Contributor

bors commented Mar 20, 2015

💔 Test failed - auto-win-32-opt

@alexcrichton
Copy link
Member Author

@bors: r=aturon bc09a97

@bors
Copy link
Contributor

bors commented Mar 20, 2015

⌛ Testing commit bc09a97 with merge d56eb07...

@bors
Copy link
Contributor

bors commented Mar 20, 2015

💔 Test failed - auto-mac-64-opt

@alexcrichton
Copy link
Member Author

@bors: r=aturon e8daec8

@bors
Copy link
Contributor

bors commented Mar 21, 2015

⌛ Testing commit e8daec8 with merge eaf8fe0...

@bors
Copy link
Contributor

bors commented Mar 21, 2015

💔 Test failed - auto-mac-64-opt

This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
@alexcrichton
Copy link
Member Author

@bors: r=aturon 212e031

@bors
Copy link
Contributor

bors commented Mar 21, 2015

⌛ Testing commit 212e031 with merge ecf8c64...

bors added a commit that referenced this pull request Mar 21, 2015
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes #23377
Closes #23378
@bors bors merged commit 212e031 into rust-lang:master Mar 21, 2015
@alexcrichton alexcrichton deleted the less-prelude branch March 27, 2015 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std::io::prelude should stop renaming Seek std::prelude::v1 still references old_path and old_io
5 participants