-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collections: Remove all collections traits #18474
Conversation
I'm building off this specualtively. Got this:
|
@alexcrichton Ah, these are |
ffd7e03
to
ad6e5d3
Compare
Thanks for the heads up @gankro! I've updated to hopefully compile on windows as well now |
ack, and now you have merge conflicts. So many collection changes 😭 |
ad6e5d3
to
4490bcd
Compare
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
//! Container traits for collections. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how this comment relates to the rest of the file.
4490bcd
to
75dd1cf
Compare
Conflicts: src/libstd/path/mod.rs
Conflicts: src/libstd/path/mod.rs
Needs a rebase |
75dd1cf
to
5dd5f6a
Compare
5dd5f6a
to
474c386
Compare
Look, @bors. I know you really like generic collection programming, but you've gotta let go. Just... come on. 😞 |
As part of the collections reform RFC, this commit removes all collections traits in favor of inherent methods on collections themselves. All methods should continue to be available on all collections. This is a breaking change with all of the collections traits being removed and no longer being in the prelude. In order to update old code you should move the trait implementations to inherent implementations directly on the type itself. Note that some traits had default methods which will also need to be implemented to maintain backwards compatibility. [breaking-change] cc rust-lang#18424
474c386
to
21ac985
Compare
As part of the collections reform RFC, this commit removes all collections traits in favor of inherent methods on collections themselves. All methods should continue to be available on all collections. This is a breaking change with all of the collections traits being removed and no longer being in the prelude. In order to update old code you should move the trait implementations to inherent implementations directly on the type itself. Note that some traits had default methods which will also need to be implemented to maintain backwards compatibility. [breaking-change] cc #18424
Awesome! Building my patch now. |
Make bracket typing handler work on more things
As part of the collections reform RFC, this commit removes all collections
traits in favor of inherent methods on collections themselves. All methods
should continue to be available on all collections.
This is a breaking change with all of the collections traits being removed and
no longer being in the prelude. In order to update old code you should move the
trait implementations to inherent implementations directly on the type itself.
Note that some traits had default methods which will also need to be implemented
to maintain backwards compatibility.
[breaking-change]
cc #18424