diff --git a/compiler/rustc_next_trait_solver/src/canonical/mod.rs b/compiler/rustc_next_trait_solver/src/canonical/mod.rs index f325862102318..153f4115302eb 100644 --- a/compiler/rustc_next_trait_solver/src/canonical/mod.rs +++ b/compiler/rustc_next_trait_solver/src/canonical/mod.rs @@ -162,7 +162,20 @@ where let prev_universe = delegate.universe(); let universes_created_in_query = response.max_universe.index(); for _ in 0..universes_created_in_query { - delegate.create_next_universe(); + let new_universe = delegate.create_next_universe(); + if delegate.cx().assumptions_on_binders() { + // FIXME(-Zassumptions-on-binders): Remove this temporary workaround once + // opaque types no longer escape query responses with query-created placeholders. + // Region constraints involving query-created placeholders were handled inside + // the query. However, the placeholders can still escape in other response + // fields, such as opaque type constraints. To avoid triggering + // assertions, we explicitly insert empty assumptions for the + // recreated universes here. + delegate.insert_placeholder_assumptions( + new_universe, + Some(rustc_type_ir::region_constraint::Assumptions::empty()), + ); + } } let var_values = response.value.var_values(); diff --git a/tests/ui/assumptions_on_binders/canonical-response-placeholder-assumptions-issue-159889.rs b/tests/ui/assumptions_on_binders/canonical-response-placeholder-assumptions-issue-159889.rs new file mode 100644 index 0000000000000..29c4d8a6a02a3 --- /dev/null +++ b/tests/ui/assumptions_on_binders/canonical-response-placeholder-assumptions-issue-159889.rs @@ -0,0 +1,24 @@ +//@ compile-flags: -Znext-solver=globally -Zassumptions-on-binders + +#![feature(type_alias_impl_trait)] + +// Regression test for #159889. Normalizing `FooAssoc<'a>` returns an opaque type constraint +// containing a query-created placeholder. Applying that response recreates its universe in the +// caller, where it must have an assumptions entry before eager placeholder handling visits it. + +trait Trait { + type Assoc<'a>: ?Sized; +} + +type Foo = impl for<'a> Trait = FooAssoc<'a>>; +type FooAssoc<'a> = impl ?Sized; + +impl Trait for () { + type Assoc<'a> = FooAssoc<'a>; +} + +#[define_opaque(Foo)] +fn foo() -> Foo {} +//~^ ERROR item does not constrain `Foo::{opaque#0}` + +fn main() {} diff --git a/tests/ui/assumptions_on_binders/canonical-response-placeholder-assumptions-issue-159889.stderr b/tests/ui/assumptions_on_binders/canonical-response-placeholder-assumptions-issue-159889.stderr new file mode 100644 index 0000000000000..87b225e58c06b --- /dev/null +++ b/tests/ui/assumptions_on_binders/canonical-response-placeholder-assumptions-issue-159889.stderr @@ -0,0 +1,15 @@ +error: item does not constrain `Foo::{opaque#0}` + --> $DIR/canonical-response-placeholder-assumptions-issue-159889.rs:21:4 + | +LL | fn foo() -> Foo {} + | ^^^ + | + = note: consider removing `#[define_opaque]` or adding an empty `#[define_opaque()]` +note: this opaque type is supposed to be constrained + --> $DIR/canonical-response-placeholder-assumptions-issue-159889.rs:13:12 + | +LL | type Foo = impl for<'a> Trait = FooAssoc<'a>>; + | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +error: aborting due to 1 previous error +