Minor refactoring and features in rustc driver for embedders #15820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's harder to run rustc correctly without it.
Helpful for users of rustc as a library.
This provides a way for clients of the rustc library to add their own features to the pipeline.
This adds the alt_std_name field to the Session's Options type. I'm using this in an external tool to control which libraries a crate links to.
| @@ -97,6 +97,7 @@ pub struct Options { | |||
| pub color: ColorConfig, | |||
| pub externs: HashMap<String, Vec<String>>, | |||
| pub crate_name: Option<String>, | |||
| pub alt_std_name: Option<String> | |||
|
r=me with the docs & |
bjorn3
added a commit
to bjorn3/rust
that referenced
this pull request
Feb 11, 2022
This option introduced in rust-lang#15820 allows a custom crate to be imported in the place of std, but with the name std. I don't think there is any value to this. At most it is confusing users of a driver that uses this option. There are no users of this option on github. If anyone still needs it, they can emulate it injecting #![no_core] in addition to their own prelude.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some pain points I found while working on a tool that embeds rustc. These changes save me from copy-pasting 500 lines from rustc.
Two refactorings:
monitoris public. Need it to run the compiler properly.Two minor features:
alt_std_namethat can be used to override the crate that is automatically linked asextern crate std = "name";. I'm using this for customization.compile_inputtakes aOption<Plugins>to customize the compiler pipeline programmatically.Neither of the two new features are exposed via command line flags since their general utility isn't obvious.