Skip to content

Fix ICE when include_str! reads binary files #149321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2025
Merged

Fix ICE when include_str! reads binary files #149321

merged 1 commit into from
Nov 28, 2025

Conversation

@reddevilmidzy
Copy link
Contributor

@reddevilmidzy reddevilmidzy commented Nov 25, 2025 •
edited
Loading

ICE occurred when an invalid UTF8 file with an absolute path were included.

resolve: #149304

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 25, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@reddevilmidzy
Copy link
Contributor Author

reddevilmidzy commented Nov 26, 2025

Okay, the invalid bytes are all different..

reddevilmidzy
reddevilmidzy commented Nov 26, 2025
View reviewed changes
@reddevilmidzy reddevilmidzy marked this pull request as ready for review November 26, 2025 09:41
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2025

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lcnr
Copy link
Contributor

lcnr commented Nov 26, 2025

@rustbot reroll

@rustbot rustbot assigned petrochenkov and unassigned lcnr Nov 26, 2025
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 27, 2025
reddevilmidzy
reddevilmidzy commented Nov 27, 2025
View reviewed changes
Copy link
Contributor Author

@reddevilmidzy reddevilmidzy left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot ready

(tidy awesome...)

View changes since this review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 27, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2025
@reddevilmidzy
Copy link
Contributor Author

reddevilmidzy commented Nov 28, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2025
@petrochenkov
Copy link
Contributor

petrochenkov commented Nov 28, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 28, 2025

📌 Commit 3f943fb has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 28, 2025
Merged
bors added a commit that referenced this pull request Nov 28, 2025
@bors
Auto merge of #149419 - matthiaskrgr:rollup-v3q93fq, r=matthiaskrgr
089bfa2 
Rollup of 6 pull requests

Successful merges:

 - #147952 (Add a timeout to the `remote-test-client` connection)
 - #149321 (Fix ICE when include_str! reads binary files)
 - #149398 (add regression test for issue #143987)
 - #149411 (Tidying up UI tests [5/N])
 - #149413 (add test for issue 143821)
 - #149415 (Remove test-float-parse from workspace list in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 28, 2025
@bors
Auto merge of #149419 - matthiaskrgr:rollup-v3q93fq, r=matthiaskrgr
cc3eee7 
Rollup of 6 pull requests

Successful merges:

 - #147952 (Add a timeout to the `remote-test-client` connection)
 - #149321 (Fix ICE when include_str! reads binary files)
 - #149398 (add regression test for issue #143987)
 - #149411 (Tidying up UI tests [5/N])
 - #149413 (add test for issue 143821)
 - #149415 (Remove test-float-parse from workspace list in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6d4e3f8 into rust-lang:main Nov 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 28, 2025
rust-timer added a commit that referenced this pull request Nov 28, 2025
@rust-timer
Unrolled build for #149321
ad30afe 
Rollup merge of #149321 - reddevilmidzy:ice, r=petrochenkov

Fix ICE when include_str! reads binary files

ICE occurred when an invalid UTF8 file with an absolute path were included.

resolve: #149304
@reddevilmidzy reddevilmidzy deleted the ice branch November 29, 2025 00:53
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 29, 2025
@bors
Auto merge of #149419 - matthiaskrgr:rollup-v3q93fq, r=matthiaskrgr
5f476c2 
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#147952 (Add a timeout to the `remote-test-client` connection)
 - rust-lang/rust#149321 (Fix ICE when include_str! reads binary files)
 - rust-lang/rust#149398 (add regression test for issue rust-lang/rust#143987)
 - rust-lang/rust#149411 (Tidying up UI tests [5/N])
 - rust-lang/rust#149413 (add test for issue 143821)
 - rust-lang/rust#149415 (Remove test-float-parse from workspace list in tidy)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels

A-tidy Area: The tidy tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

ICE: Annotation range 24..24 is beyond the end of buffer 0

6 participants

@reddevilmidzy @rust-log-analyzer @rustbot @lcnr @petrochenkov @bors