Skip to content

Conversation

@notriddle
Copy link
Contributor

Part of #130676

Adds documentation and a feature change aimed at making this usable without breaking backwards compat.

cc @EtomicBomb

This fixes a limitation that prevented me from adding it to Cargo.
The rust compiler-docs bundle is built by running multiple `cargo`
commands in succession, and I want to support that, so I'm stuck
putting the doc parts all in one directory, so that subsequent
`cargo` runs can pick up the previous runs' data. It's less clean,
but it should still be usable in hermetic build environments if
you give every crate its own directory (which you needed to do
before, oddly enough).
@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Oct 28, 2025
@EtomicBomb
Copy link
Contributor

Thank you for putting this together! I appreciate the docs and the rmake test and the added clarity.

@notriddle notriddle marked this pull request as ready for review November 22, 2025 21:26
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 22, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot

This comment was marked as outdated.

@jieyouxu

This comment was marked as outdated.

@rustbot rustbot assigned Mark-Simulacrum and unassigned jieyouxu Nov 24, 2025
@jieyouxu
Copy link
Member

r? rustdoc

@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 24, 2025

📌 Commit 0786642 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 24, 2025
rustdoc: make mergeable crate info more usable

Part of rust-lang#130676

Adds documentation and a feature change aimed at making this usable without breaking backwards compat.

cc `@EtomicBomb`
bors added a commit that referenced this pull request Nov 24, 2025
Rollup of 3 pull requests

Successful merges:

 - #148122 (Make deref_nullptr deny by default instead of warn)
 - #148234 (rustdoc: make mergeable crate info more usable)
 - #149255 (Use `let...else` consistently in user-facing diagnostics)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 24, 2025
Rollup of 6 pull requests

Successful merges:

 - #148234 (rustdoc: make mergeable crate info more usable)
 - #149201 (Add suggest alternatives for Out-of-range \x escapes)
 - #149208 ([rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls)
 - #149252 (miri: use `tikv-jemalloc-sys` from sysroot)
 - #149255 (Use `let...else` consistently in user-facing diagnostics)
 - #149275 (Fix missing double-quote in `std::env::consts::OS` values)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit be49e00 into rust-lang:main Nov 24, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 24, 2025
rust-timer added a commit that referenced this pull request Nov 24, 2025
Rollup merge of #148234 - notriddle:doc-cci, r=GuillaumeGomez

rustdoc: make mergeable crate info more usable

Part of #130676

Adds documentation and a feature change aimed at making this usable without breaking backwards compat.

cc ``@EtomicBomb``
@notriddle notriddle deleted the doc-cci branch November 25, 2025 01:24
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 25, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#148234 (rustdoc: make mergeable crate info more usable)
 - rust-lang/rust#149201 (Add suggest alternatives for Out-of-range \x escapes)
 - rust-lang/rust#149208 ([rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls)
 - rust-lang/rust#149252 (miri: use `tikv-jemalloc-sys` from sysroot)
 - rust-lang/rust#149255 (Use `let...else` consistently in user-facing diagnostics)
 - rust-lang/rust#149275 (Fix missing double-quote in `std::env::consts::OS` values)

r? `@ghost`
`@rustbot` modify labels: rollup
github-actions bot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Nov 27, 2025
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#148234 (rustdoc: make mergeable crate info more usable)
 - rust-lang/rust#149201 (Add suggest alternatives for Out-of-range \x escapes)
 - rust-lang/rust#149208 ([rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls)
 - rust-lang/rust#149252 (miri: use `tikv-jemalloc-sys` from sysroot)
 - rust-lang/rust#149255 (Use `let...else` consistently in user-facing diagnostics)
 - rust-lang/rust#149275 (Fix missing double-quote in `std::env::consts::OS` values)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants