Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid opaque type not constrained errors in the presence of other errors #133850

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 4, 2024

pulled out of #128440

These errors carry no new information if the opaque type was actually used in a constraining (but erroneous) way somewhere.

@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 4, 2024
@compiler-errors
Copy link
Member

r? compiler-errors @bors r+

@bors
Copy link
Contributor

bors commented Dec 4, 2024

📌 Commit a91c361 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned pnkfelix Dec 4, 2024
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#133737 (Include LLDB and GDB visualizers in MSVC distribution)
 - rust-lang#133774 (Make CoercePointee errors translatable)
 - rust-lang#133831 (Don't try and handle unfed `type_of` on anon consts)
 - rust-lang#133847 (Remove `-Zshow-span`.)
 - rust-lang#133849 (coverage: Use a separate counter type and simplification step during counter creation)
 - rust-lang#133850 (Avoid `opaque type not constrained` errors in the presence of other errors)
 - rust-lang#133851 (Stop git from merging generated files)
 - rust-lang#133856 (Update sysinfo version to 0.33.0)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ea4e719 into rust-lang:master Dec 4, 2024
6 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 4, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 4, 2024
Rollup merge of rust-lang#133850 - oli-obk:push-xryukktpyooq, r=compiler-errors

Avoid `opaque type not constrained` errors in the presence of other errors

pulled out of rust-lang#128440

These errors carry no new information if the opaque type was actually used in a constraining (but erroneous) way somewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants