Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump unsupported ubuntu CI images to 24.04 LTS #133532

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Bump unsupported ubuntu CI images to 24.04 LTS #133532

merged 1 commit into from
Dec 1, 2024

Conversation

rami3l
Copy link
Member

@rami3l rami3l commented Nov 27, 2024 •
edited by Urgau
Loading

Closes #133531.

try-job: arm-android
try-job: dist-android
try-job: dist-ohos

@rustbot
Copy link
Collaborator

rustbot commented Nov 27, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 27, 2024
@Urgau
Copy link
Member

Urgau commented Nov 27, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 27, 2024
@bors
Auto merge of rust-lang#133532 - rami3l:ci/bump-ubuntu, r=<try>
41a5914 
Bump unsupported `ubuntu` CI images to 24.04 LTS

Closes rust-lang#133531.

try-job: arm-android
try-job: dist-android
try-job: dist-ohos
@bors
Copy link
Contributor

bors commented Nov 27, 2024

⌛ Trying commit 48c5418 with merge 41a5914...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Nov 27, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2024
@pan93412
Copy link
Contributor 

  3.783 E: Unable to locate package libncurses5

Seems like it should be replaced to libncurses (which installs v6)? Reference: rvm/rvm#5475

@rami3l
Copy link
Member Author

rami3l commented Nov 28, 2024

@bors try

@Urgau Thanks for the quick response! I've double checked these dockerfiles and have made some dependency updates. After that all three of them can build without issues on my machine (I'm not sure about the runtime behavior though). Shall we try again?

@rami3l
Copy link
Member Author

rami3l commented Nov 28, 2024

@bors try

@bors
Copy link
Contributor

bors commented Nov 28, 2024

@rami3l: 🔑 Insufficient privileges: not in try users

@Urgau
Copy link
Member

Urgau commented Nov 28, 2024

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2024
@bors
Auto merge of rust-lang#133532 - rami3l:ci/bump-ubuntu, r=<try>
7a29e49 
Bump unsupported `ubuntu` CI images to 24.04 LTS

Closes rust-lang#133531.

try-job: arm-android
try-job: dist-android
try-job: dist-ohos
@bors
Copy link
Contributor

bors commented Nov 28, 2024

⌛ Trying commit cddc831 with merge 7a29e49...

@rami3l
Copy link
Member Author

rami3l commented Nov 28, 2024

r? Urgau

@rustbot rustbot assigned Urgau and unassigned Mark-Simulacrum Nov 28, 2024
@bors
Copy link
Contributor

bors commented Nov 28, 2024

☀️ Try build successful - checks-actions
Build commit: 7a29e49 (7a29e492c4ac21104160846683f0f1a21cd06f76)

@Urgau
Copy link
Member

Urgau commented Nov 28, 2024

LGTM, but I'm not a infra reviewer.

r? @Mark-Simulacrum

@rustbot rustbot assigned Mark-Simulacrum and unassigned Urgau Nov 28, 2024
@Kobzol
Copy link
Contributor

Kobzol commented Nov 28, 2024

This seems uncontroversial, and since 23.04 is deprecated and soon EOL, we'll need to upgrade the base image anyway.

@bors r+

@bors
Copy link
Contributor

bors commented Nov 28, 2024

📌 Commit cddc831 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2024
@matthiaskrgr
Copy link
Member

@bors rollup=never

@bors
Copy link
Contributor

bors commented Dec 1, 2024

⌛ Testing commit cddc831 with merge 1555074...

@bors
Copy link
Contributor

bors commented Dec 1, 2024

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 1555074 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 1, 2024
@bors bors merged commit 1555074 into rust-lang:master Dec 1, 2024
7 checks passed
@rustbot rustbot added this to the 1.85.0 milestone Dec 1, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1555074): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.479s -> 768.018s (-0.06%)
Artifact size: 332.12 MiB -> 332.20 MiB (0.02%)

@rami3l rami3l mentioned this pull request Dec 2, 2024
Merged
1 task
@rami3l rami3l deleted the ci/bump-ubuntu branch December 2, 2024 01:50
@rami3l rami3l mentioned this pull request Dec 7, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.85.0
Development

Successfully merging this pull request may close these issues.

arm-android/Dockerfile is based on the now outdated Ubuntu 23.04
10 participants
@rami3l @rustbot @Urgau @bors @rust-log-analyzer @pan93412 @Kobzol @matthiaskrgr @rust-timer @Mark-Simulacrum