Skip to content

For expr return (_ = 42); unused_paren lint should not be triggered #132936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2024
Merged

For expr return (_ = 42); unused_paren lint should not be triggered #132936

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33d3c27
For expr `return (_ = 42);` unused_paren lint should not be triggered
surechen Nov 12, 2024
3a74bce
Adding `BreakValue` to UnusedDelimsCtx to make `UnusedParens` and `Un…
surechen Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions compiler/rustc_lint/src/unused.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,6 +1063,8 @@ impl UnusedDelimLint for UnusedParens {
_,
_,
) if node.is_lazy()))
&& !(ctx == UnusedDelimsCtx::ReturnValue
&& matches!(inner.kind, ast::ExprKind::Assign(_, _, _)))
{
self.emit_unused_delims_expr(cx, value, ctx, left_pos, right_pos, is_kw)
}
Expand Down
9 changes: 9 additions & 0 deletions tests/ui/lint/unused/unused-parens-assign-expr-in-ret-issue-131989.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
//@ check-pass
#![warn(unused_parens)]

fn foo() {
return (_ = 42);
// lint unused_parens should not be triggered here.
}

fn main() {}
Loading