-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert MSVC CI changes #131133
Closed
Closed
Revert MSVC CI changes #131133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
labels
Oct 2, 2024
@bors try |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 2, 2024
…try> Revert MSVC CI changes - rust-lang#130151 - rust-lang#130072 try-job: x86_64-msvc try-job: x86_64-msvc-ext
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 2, 2024
…=<try> [experiment] Revert msvc ci changes 2 Duplicate of rust-lang#131133 so we can have two try jobs going at once. r? `@ghost` try-job: x86_64-msvc try-job: x86_64-msvc-ext
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 2, 2024
... Wait, is that an ICE? |
Yes but it's in an mdbook test which is allowed to fail. The actual failure came later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
CI-spurious-fail-msvc
CI spurious failure: target env msvc
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We finished updating all major lockfiles to a
cc
version that includes rust-lang/cc-rs#1215. See if this allows us to revert CI changes that were made to help #127883.try-job: x86_64-msvc
try-job: x86_64-msvc-ext
r? @ghost