Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #130631

Merged
merged 23 commits into from
Sep 20, 2024
Merged

Rollup of 7 pull requests #130631

merged 23 commits into from
Sep 20, 2024

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    0444056 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Begin experimental support for pin reborrowing

    This commit adds basic support for reborrowing `Pin` types in argument
    position. At the moment it only supports reborrowing `Pin<&mut T>` as
    `Pin<&mut T>` by inserting a call to `Pin::as_mut()`, and only in
    argument position (not as the receiver in a method call).
    eholk committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7b7992f View commit details
    Browse the repository at this point in the history
  2. Apply code review suggestions

    eholk committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a73c8b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Allow shortening reborrows

    Generating a call to `as_mut()` let to more restrictive borrows than
    what reborrowing usually gives us. Instead, we change the desugaring to
    reborrow the pin internals directly which makes things more expressive.
    eholk committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    b2b76fb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    92a5d21 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a18800f View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Configuration menu
    Copy the full SHA
    bfadadf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9104632 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    660210c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    38bf289 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    55058b6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5a219cb View commit details
    Browse the repository at this point in the history
  7. add comment

    lcnr committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9613f48 View commit details
    Browse the repository at this point in the history
  8. Add arm64e-apple-tvos target

    arttet committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    340b38e View commit details
    Browse the repository at this point in the history
  9. update tests

    lcnr committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a6aeba8 View commit details
    Browse the repository at this point in the history
  10. Add Vec::as_non_null

    theemathas committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ff86269 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#128209 - beetrees:no-macos-10.10, r=jieyouxu

    Remove macOS 10.10 dynamic linker bug workaround
    
    Rust's current minimum macOS version is 10.12, so the hack can be removed. This PR also updates the `remove_dir_all` docs to reflect that all supported macOS versions are protected against TOCTOU race conditions (the fallback implementation was already removed in rust-lang#127683).
    
    try-job: dist-x86_64-apple
    try-job: dist-aarch64-apple
    try-job: dist-apple-various
    try-job: aarch64-apple
    try-job: x86_64-apple-1
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    bf6389f View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#130526 - eholk:pin-reborrow, r=compiler-errors

    Begin experimental support for pin reborrowing
    
    This commit adds basic support for reborrowing `Pin` types in argument position. At the moment it only supports reborrowing `Pin<&mut T>` as `Pin<&mut T>` by inserting a call to `Pin::as_mut()`, and only in argument position (not as the receiver in a method call).
    
    This PR makes the following example compile:
    
    ```rust
    #![feature(pin_ergonomics)]
    
    fn foo(_: Pin<&mut Foo>) {
    }
    
    fn bar(mut x: Pin<&mut Foo>) {
        foo(x);
        foo(x);
    }
    ```
    
    Previously, you would have had to write `bar` as:
    
    ```rust
    fn bar(mut x: Pin<&mut Foo>) {
        foo(x.as_mut());
        foo(x);
    }
    ```
    
    Tracking:
    
    - rust-lang#130494
    
    r? `@compiler-errors`
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fe5f734 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#130611 - bjoernager:const-char-encode-utf8,…

    … r=dtolnay
    
    Address diagnostics regression for `const_char_encode_utf8`.
    
    Relevant tracking issue: rust-lang#130512
    
    This PR regains full diagnostics for non-const calls to `char::encode_utf8`.
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2a3f353 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#130614 - arttet:arm64e-apple-tvos, r=bjorn3

    Add arm64e-apple-tvos target
    
    This introduces
    
    * `arm64e-apple-tvos`
    
    ## Tier 3 Target Policy
    
    > * A tier 3 target must have a designated developer or developers (the "target
    maintainers") on record to be CCed when issues arise regarding the target.
    (The mechanism to track and CC such developers may evolve over time.)
    
    I will be a target maintainer.
    
    > * Targets must use naming consistent with any existing targets; for instance, a
    target for the same CPU or OS as an existing Rust target should use the same
    name for that CPU or OS. Targets should normally use the same names and
    naming conventions as used elsewhere in the broader ecosystem beyond Rust
    (such as in other toolchains), unless they have a very good reason to
    diverge. Changing the name of a target can be highly disruptive, especially
    once the target reaches a higher tier, so getting the name right is important
    even for a tier 3 target.
    Target names should not introduce undue confusion or ambiguity unless
    absolutely necessary to maintain ecosystem compatibility. For example, if
    the name of the target makes people extremely likely to form incorrect
    beliefs about what it targets, the name should be changed or augmented to
    disambiguate it.
    If possible, use only letters, numbers, dashes and underscores for the name.
    Periods (.) are known to cause issues in Cargo.
    
    The `arm64e-apple-tvos` target names like `arm64e-apple-ios`, `arm64e-apple-darwin`.
    So, **I have chosen this name because there are similar triplets in LLVM**. I think there are no more suitable names for these targets.
    
    > * Tier 3 targets may have unusual requirements to build or use, but must not
    create legal issues or impose onerous legal terms for the Rust project or for
    Rust developers or users.
    The target must not introduce license incompatibilities.
    Anything added to the Rust repository must be under the standard Rust
    license (MIT OR Apache-2.0).
    The target must not cause the Rust tools or libraries built for any other
    host (even when supporting cross-compilation to the target) to depend
    on any new dependency less permissive than the Rust licensing policy. This
    applies whether the dependency is a Rust crate that would require adding
    new license exceptions (as specified by the tidy tool in the
    rust-lang/rust repository), or whether the dependency is a native library
    or binary. In other words, the introduction of the target must not cause a
    user installing or running a version of Rust or the Rust tools to be
    subject to any new license requirements.
    Compiling, linking, and emitting functional binaries, libraries, or other
    code for the target (whether hosted on the target itself or cross-compiling
    from another target) must not depend on proprietary (non-FOSS) libraries.
    Host tools built for the target itself may depend on the ordinary runtime
    libraries supplied by the platform and commonly used by other applications
    built for the target, but those libraries must not be required for code
    generation for the target; cross-compilation to the target must not require
    such libraries at all. For instance, rustc built for the target may
    depend on a common proprietary C runtime library or console output library,
    but must not depend on a proprietary code generation library or code
    optimization library. Rust's license permits such combinations, but the
    Rust project has no interest in maintaining such combinations within the
    scope of Rust itself, even at tier 3.
    "onerous" here is an intentionally subjective term. At a minimum, "onerous"
    legal/licensing terms include but are not limited to: non-disclosure
    requirements, non-compete requirements, contributor license agreements
    (CLAs) or equivalent, "non-commercial"/"research-only"/etc terms,
    requirements conditional on the employer or employment of any particular
    Rust developers, revocable terms, any requirements that create liability
    for the Rust project or its developers or users, or any requirements that
    adversely affect the livelihood or prospects of the Rust project or its
    developers or users.
    
    No dependencies were added to Rust.
    
    > * Neither this policy nor any decisions made regarding targets shall create any
    binding agreement or estoppel by any party. If any member of an approving
    Rust team serves as one of the maintainers of a target, or has any legal or
    employment requirement (explicit or implicit) that might affect their
    decisions regarding a target, they must recuse themselves from any approval
    decisions regarding the target's tier status, though they may otherwise
    participate in discussions.
    >    * This requirement does not prevent part or all of this policy from being
    cited in an explicit contract or work agreement (e.g. to implement or
    maintain support for a target). This requirement exists to ensure that a
    developer or team responsible for reviewing and approving a target does not
    face any legal threats or obligations that would prevent them from freely
    exercising their judgment in such approval, even if such judgment involves
    subjective matters or goes beyond the letter of these requirements.
    
    Understood.
    I am not a member of a Rust team.
    
    > * Tier 3 targets should attempt to implement as much of the standard libraries
    as possible and appropriate (core for most targets, alloc for targets
    that can support dynamic memory allocation, std for targets with an
    operating system or equivalent layer of system-provided functionality), but
    may leave some code unimplemented (either unavailable or stubbed out as
    appropriate), whether because the target makes it impossible to implement or
    challenging to implement. The authors of pull requests are not obligated to
    avoid calling any portions of the standard library on the basis of a tier 3
    target not implementing those portions.
    
    Understood.
    `std` is supported.
    
    > * The target must provide documentation for the Rust community explaining how
    to build for the target, using cross-compilation if possible. If the target
    supports running binaries, or running tests (even if they do not pass), the
    documentation must explain how to run such binaries or tests for the target,
    using emulation if possible or dedicated hardware if necessary.
    
    Building is described in the derived target doc.
    
    > * Tier 3 targets must not impose burden on the authors of pull requests, or
    other developers in the community, to maintain the target. In particular,
    do not post comments (automated or manual) on a PR that derail or suggest a
    block on the PR based on a tier 3 target. Do not send automated messages or
    notifications (via any medium, including via `@)` to a PR author or others
    involved with a PR regarding a tier 3 target, unless they have opted into
    such messages.
    >    * Backlinks such as those generated by the issue/PR tracker when linking to
    an issue or PR are not considered a violation of this policy, within
    reason. However, such messages (even on a separate repository) must not
    generate notifications to anyone involved with a PR who has not requested
    such notifications.
    
    Understood.
    
    > * Patches adding or updating tier 3 targets must not break any existing tier 2
    or tier 1 target, and must not knowingly break another tier 3 target without
    approval of either the compiler team or the maintainers of the other tier 3
    target.
    >     * In particular, this may come up when working on closely related targets,
    such as variations of the same architecture with different features. Avoid
    introducing unconditional uses of features that another variation of the
    target may not have; use conditional compilation or runtime detection, as
    appropriate, to let each target run code supported by that target.
    
    Understood.
    
    rust-lang#121663
    rust-lang#73628
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    df2b730 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#130617 - lcnr:nalgebra-hang-3, r=compiler-e…

    …rrors
    
    bail if there are too many non-region infer vars in the query response
    
    A minimal fix for the hang in nalgebra. If the query response would result in too many distinct non-region inference variables, simply overwrite the result with overflow. This should either happen if the result already has too many distinct type inference variables, or if evaluating the query encountered a lot of ambiguous associated types. In both cases it's straightforward to wait until the aliases are no longer ambiguous and then try again.
    
    r? `@compiler-errors`
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7adf4c2 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#130619 - GuillaumeGomez:scraped-examples-he…

    …ight, r=notriddle
    
    Fix scraped examples height
    
    Fixes [rust-lang#130562](rust-lang#130562).
    
    You can test it [here](https://rustdoc.crud.net/imperio/scraped-examples-height/doc/scrape_examples/fn.test_many.html).
    
    I also used this opportunity to reduce the padding on line numbers:
    
    | before | after |
    | - | - |
    | ![Screenshot from 2024-09-20 16-20-40](https://github.com/user-attachments/assets/9434704c-afe0-4ec3-a1dc-6f3c16d03b3b) | ![Screenshot from 2024-09-20 16-20-13](https://github.com/user-attachments/assets/f3bd01bf-760a-4acd-ba34-8e7db083245a) |
    
    r? `@notriddle`
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5708062 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#130624 - theemathas:vec_as_non_null, r=Nora…

    …trieb
    
    Add `Vec::as_non_null`
    
    Implements the ACP: rust-lang/libs-team#440
    
    The documentation is mostly copied from the existing `Vec::as_mut_ptr` method.
    
    I am adding this method to the already-existing `box_vec_non_null` feature tracked at rust-lang#130364.
    GuillaumeGomez authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    81b818e View commit details
    Browse the repository at this point in the history