Codegen const panic messages as function calls

[Mark-Simulacrum]

This skips emitting extra arguments at every callsite (of which there
can be many). For a librustc_driver build with overflow checks enabled,
this cuts 0.7MB from the resulting shared library (see perf).

A sample improvement from nightly:

        leaq    str.0(%rip), %rdi
        leaq    .Lalloc_d6aeb8e2aa19de39a7f0e861c998af13(%rip), %rdx
        movl    $25, %esi
        callq   *_ZN4core9panicking5panic17h17cabb89c5bcc999E@GOTPCREL(%rip)

to this PR:

        leaq    .Lalloc_d6aeb8e2aa19de39a7f0e861c998af13(%rip), %rdi
        callq   *_RNvNtNtCsduqIKoij8JB_4core9panicking11panic_const23panic_const_div_by_zero@GOTPCREL(%rip)

[Mark-Simulacrum]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 12078d5 with merge 02fafb5...

[bors]

☀️ Try build successful - checks-actions
Build commit: 02fafb5 (02fafb59be39ebb5f29c7c72f80fc9b155286a0a)

[rust-timer]

Finished benchmarking commit (02fafb5): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.2%, 0.6%]	5
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[0.2%, 0.6%]	5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.7%	[-5.6%, -1.8%]	14
Improvements ✅ (secondary)	-3.2%	[-7.3%, -0.8%]	32
All ❌✅ (primary)	-2.4%	[-5.6%, 2.6%]	15

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.0%, 0.9%]	30
Regressions ❌ (secondary)	0.3%	[0.0%, 6.4%]	28
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.0%]	41
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	3
All ❌✅ (primary)	-0.0%	[-0.4%, 0.9%]	71

Bootstrap: 669.037s -> 669.296s (0.04%)
Artifact size: 312.76 MiB -> 312.71 MiB (-0.02%)

[Mark-Simulacrum]

@bors try @rust-timer queue

[bors]

⌛ Trying commit dfac628 with merge 801226c...

[bors]

💔 Test failed - checks-actions

[Mark-Simulacrum]

@bors try @rust-timer queue

[rustbot]

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

[bors]

⌛ Testing commit 00f4daa with merge 297ddf1...

[bors]

💔 Test failed - checks-actions

[rust-log-analyzer]

The job x86_64-msvc-ext failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

-- Configuring done (35.2s)
-- Generating done (2.6s)
-- Build files have been written to: C:/a/rust/rust/build/x86_64-pc-windows-msvc/llvm/build
running: "cmake" "--build" "." "--target" "install" "--config" "Release" "--" "-j" "8"
ninja: error: build.ninja:3780: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you
thread 'main' panicked at C:\Users\runneradmin\.cargo\registry\src\index.crates.io-6f17d22bba15001f\cmake-0.1.48\src\lib.rs:975:5:

command did not execute successfully, got: exit code: 1

[Noratrieb]

@bors treeclosed=50
https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/ninja.20build.20failing

[Mark-Simulacrum]

@bors retry since the failure was spurious

[bors]

⌛ Testing commit 00f4daa with merge db2f975...

[bors]

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing db2f975 to master...

[rust-timer]

Finished benchmarking commit (db2f975): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.3%, 0.4%]	2
Regressions ❌ (secondary)	0.3%	[0.2%, 0.4%]	7
Improvements ✅ (primary)	-0.7%	[-0.9%, -0.6%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.3%	[-0.9%, 0.4%]	5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.2%	[-0.2%, -0.2%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.0%]	4
Regressions ❌ (secondary)	0.0%	[0.0%, 0.0%]	34
Improvements ✅ (primary)	-0.1%	[-0.4%, -0.0%]	61
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	9
All ❌✅ (primary)	-0.1%	[-0.4%, 0.0%]	65

Bootstrap: 668.388s -> 669.604s (0.18%)
Artifact size: 315.68 MiB -> 315.78 MiB (0.03%)