Rollup of 5 pull requests #120437

matthiaskrgr · 2024-01-28T03:48:20Z

Successful merges:

Bump Fuchsia, build tests, and use 8 core bots #120358 (Bump Fuchsia, build tests, and use 8 core bots)
Make the coroutine def id of an async closure the child of the closure def id #120402 (Make the coroutine def id of an async closure the child of the closure def id)
Stop using derivative in rustc_pattern_analysis #120420 (Stop using derivative in rustc_pattern_analysis)
Remove unnecessary unit returns in query declarations #120425 (Remove unnecessary unit returns in query declarations)
hir: Two preparatory changes for #120206 #120428 (hir: Two preparatory changes for hir: Make sure all HirIds have corresponding HIR Nodes #120206)

r? @ghost
@rustbot modify labels: rollup

This refactors run.sh to never override an explicit $CODEGEN_BACKENDS if set in the build.

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder.

For consistency with normal functions.

…e def id

It has 1-to-1 correspondence to its expression id. Also remove mostly useless `visit_let_expr`.

…ark-Simulacrum Bump Fuchsia, build tests, and use 8 core bots - Build Fuchsia on 8 cores instead of 16 - Skip building cranelift for Fuchsia - Bump Fuchsia (includes building tests) This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593. See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up. r? ````@Mark-Simulacrum````

…tree, r=cjgillot Make the coroutine def id of an async closure the child of the closure def id Adjust def collection to make the (inner) coroutine returned by an async closure be a def id child of the (outer) closure. This makes it easy to map from coroutine -> closure by using `tcx.parent`, since currently it's not trivial to do this.

…tive, r=Nilstrieb Stop using derivative in rustc_pattern_analysis CC rust-lang#109302, rust-lang/rust-analyzer#16420 (comment) r? ```@Nadrieril```

…Nilstrieb Remove unnecessary unit returns in query declarations For consistency with normal functions.

…errors hir: Two preparatory changes for rust-lang#120206 cc rust-lang#120206 r? `@compiler-errors`

matthiaskrgr · 2024-01-28T03:48:47Z

@bors r+ rollup=never p=5

bors · 2024-01-28T03:48:49Z

📌 Commit 4a759f0 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2024-01-28T08:46:07Z

⌛ Testing commit 4a759f0 with merge a162071...

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id) - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis) - rust-lang#120425 (Remove unnecessary unit returns in query declarations) - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-01-28T13:01:07Z

💥 Test timed out

matthiaskrgr · 2024-01-28T13:13:31Z

@bors retry

rust-log-analyzer · 2024-01-28T13:15:19Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-01-28T13:58:53Z

⌛ Testing commit 4a759f0 with merge 769e1fe...

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id) - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis) - rust-lang#120425 (Remove unnecessary unit returns in query declarations) - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-01-28T18:13:53Z

💥 Test timed out

matthiaskrgr · 2024-01-28T18:24:43Z

@bors retry apple dist various not starting

rust-log-analyzer · 2024-01-28T18:26:28Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2024-01-28T18:46:45Z

⌛ Testing commit 4a759f0 with merge 8d9b7de...

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id) - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis) - rust-lang#120425 (Remove unnecessary unit returns in query declarations) - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-01-28T23:01:45Z

💥 Test timed out

rust-log-analyzer · 2024-01-28T23:20:13Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

fmease · 2024-01-29T03:47:20Z

@bors retry one last time

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id) - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis) - rust-lang#120425 (Remove unnecessary unit returns in query declarations) - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-01-29T05:14:54Z

⌛ Testing commit 4a759f0 with merge abbba77...

rust-log-analyzer · 2024-01-29T06:48:52Z

The job x86_64-apple-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

SCCACHE_BUCKET=rust-lang-ci-sccache2
SCRIPT=./x.py --stage 2 test --skip tests/ui --skip tests/rustdoc --skip tests/run-make-fulldeps
SHELL=/bin/bash
SHLVL=3
SSH_AUTH_SOCK=/private/tmp/com.apple.launchd.oGJhfiHwJc/Listeners
STATS_EXTP=https://provjobdsettingscdn.blob.core.windows.net/settings/provjobdsettings-0.5.154/provjobd.data
STATS_RDCL=true
STATS_TIS=mining
STATS_TRP=true

bors · 2024-01-29T06:49:12Z

💔 Test failed - checks-actions

matthiaskrgr · 2024-01-29T07:34:32Z

well, tempted to just rollup=iffy all 5 and call it a day :|

fmease · 2024-01-29T12:17:10Z

The job x86_64-apple-1 failed!

---- core::config::config::tests::detect_src_and_out stdout ----
downloading https://static.rust-lang.org/dist/2023-12-22/rust-std-beta-x86_64-apple-darwin.tar.xz
extracting /tmp/cache/2023-12-22/rust-std-beta-x86_64-apple-darwin.tar.xz to /tmp/x86_64-apple-darwin/stage0
downloading https://static.rust-lang.org/dist/2023-12-22/rustc-beta-x86_64-apple-darwin.tar.xz
extracting /tmp/cache/2023-12-22/rustc-beta-x86_64-apple-darwin.tar.xz to /tmp/x86_64-apple-darwin/stage0
downloading https://static.rust-lang.org/dist/2023-12-22/cargo-beta-x86_64-apple-darwin.tar.xz
thread 'core::config::config::tests::detect_src_and_out' panicked at /Users/runner/work/rust/rust/src/tools/build_helper/src/util.rs:18:9:
status code: 1


failures:
    core::config::config::tests::detect_src_and_out

@onur-ozkan Any idea what might've happened here?

onur-ozkan · 2024-01-29T12:25:19Z

The job x86_64-apple-1 failed!

---- core::config::config::tests::detect_src_and_out stdout ----
downloading https://static.rust-lang.org/dist/2023-12-22/rust-std-beta-x86_64-apple-darwin.tar.xz
extracting /tmp/cache/2023-12-22/rust-std-beta-x86_64-apple-darwin.tar.xz to /tmp/x86_64-apple-darwin/stage0
downloading https://static.rust-lang.org/dist/2023-12-22/rustc-beta-x86_64-apple-darwin.tar.xz
extracting /tmp/cache/2023-12-22/rustc-beta-x86_64-apple-darwin.tar.xz to /tmp/x86_64-apple-darwin/stage0
downloading https://static.rust-lang.org/dist/2023-12-22/cargo-beta-x86_64-apple-darwin.tar.xz
thread 'core::config::config::tests::detect_src_and_out' panicked at /Users/runner/work/rust/rust/src/tools/build_helper/src/util.rs:18:9:
status code: 1


failures:
    core::config::config::tests::detect_src_and_out

@onur-ozkan Any idea what might've happened here?

I don't see any helpful information in the log. I would give it another shot since the previous attempts didn't have this issue.

tmandry and others added 13 commits January 26, 2024 13:09

Build Fuchsia on 8 cores instead of 16

40f5e68

Skip building cranelift for Fuchsia

53bf511

This refactors run.sh to never override an explicit $CODEGEN_BACKENDS if set in the build.

Bump Fuchsia (includes building tests)

afd5edc

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder.

Stop using derivative in rustc_pattern_analysis

f5c7895

Remove unnecessary unit returns in query declarations

cda898b

For consistency with normal functions.

Make the coroutine def id of an async closure the child of the closur…

5d8c178

…e def id

hir: Remove unnecessary HirId from hir::Let

5f8030d

It has 1-to-1 correspondence to its expression id. Also remove mostly useless `visit_let_expr`.

hir: Use InferArg in ArrayLen::Infer

b2b5b91

Rollup merge of rust-lang#120420 - lnicola:rm-pattern-analysis-deriva…

9b06380

…tive, r=Nilstrieb Stop using derivative in rustc_pattern_analysis CC rust-lang#109302, rust-lang/rust-analyzer#16420 (comment) r? ```@Nadrieril```

Rollup merge of rust-lang#120425 - DaniPopes:query-default-return, r=…

6b8ecea

…Nilstrieb Remove unnecessary unit returns in query declarations For consistency with normal functions.

Rollup merge of rust-lang#120428 - petrochenkov:somehir2, r=compiler-…

4a759f0

…errors hir: Two preparatory changes for rust-lang#120206 cc rust-lang#120206 r? `@compiler-errors`

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2024

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 28, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 28, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 29, 2024

fmease closed this Jan 30, 2024

matthiaskrgr deleted the rollup-h1uai71 branch March 16, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #120437

Rollup of 5 pull requests #120437

matthiaskrgr commented Jan 28, 2024

matthiaskrgr commented Jan 28, 2024

bors commented Jan 28, 2024

bors commented Jan 28, 2024

bors commented Jan 28, 2024

matthiaskrgr commented Jan 28, 2024

rust-log-analyzer commented Jan 28, 2024

bors commented Jan 28, 2024

bors commented Jan 28, 2024

matthiaskrgr commented Jan 28, 2024

rust-log-analyzer commented Jan 28, 2024

bors commented Jan 28, 2024

bors commented Jan 28, 2024

rust-log-analyzer commented Jan 28, 2024

fmease commented Jan 29, 2024

bors commented Jan 29, 2024

rust-log-analyzer commented Jan 29, 2024

bors commented Jan 29, 2024

matthiaskrgr commented Jan 29, 2024

fmease commented Jan 29, 2024

onur-ozkan commented Jan 29, 2024

Rollup of 5 pull requests #120437

Rollup of 5 pull requests #120437

Conversation

matthiaskrgr commented Jan 28, 2024

matthiaskrgr commented Jan 28, 2024

bors commented Jan 28, 2024

bors commented Jan 28, 2024

bors commented Jan 28, 2024

matthiaskrgr commented Jan 28, 2024

rust-log-analyzer commented Jan 28, 2024

bors commented Jan 28, 2024

bors commented Jan 28, 2024

matthiaskrgr commented Jan 28, 2024

rust-log-analyzer commented Jan 28, 2024

bors commented Jan 28, 2024

bors commented Jan 28, 2024

rust-log-analyzer commented Jan 28, 2024

fmease commented Jan 29, 2024

bors commented Jan 29, 2024

rust-log-analyzer commented Jan 29, 2024

bors commented Jan 29, 2024

matthiaskrgr commented Jan 29, 2024

fmease commented Jan 29, 2024

onur-ozkan commented Jan 29, 2024