[library/std] Replace condv while loop with cvar.wait_while.
#114359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
`wait_while` takes care of spurious wake-ups in centralized place, reducing chances for mistakes and potential future optimizations (who knows, maybe in future there will be no spurious wake-ups? :)
cuviper
reviewed
Aug 10, 2023
|
Thanks! @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2023
…mpiler-errors Rollup of 5 pull requests Successful merges: - rust-lang#114194 (Inline trivial (noop) flush calls) - rust-lang#114257 (Avoid using `ptr::Unique` in `LinkedList` code) - rust-lang#114359 ([library/std] Replace condv while loop with `cvar.wait_while`.) - rust-lang#114402 (Fix documentation of impl From<Vec<T>> for Rc<[T]>) - rust-lang#114715 (Revert clippy lint [`filter_map_bool_then`]) r? `@ghost` `@rustbot` modify labels: rollup
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 14, 2023
…mpiler-errors Rollup of 5 pull requests Successful merges: - rust-lang#114194 (Inline trivial (noop) flush calls) - rust-lang#114257 (Avoid using `ptr::Unique` in `LinkedList` code) - rust-lang#114359 ([library/std] Replace condv while loop with `cvar.wait_while`.) - rust-lang#114402 (Fix documentation of impl From<Vec<T>> for Rc<[T]>) - rust-lang#114715 (Revert clippy lint [`filter_map_bool_then`]) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_whiletakes care of spurious wake-ups in centralized place, reducing chances for mistakes and potential future optimizations (who knows, maybe in future there will be no spurious wake-ups? :)