Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: wrap "source" link to new line on narrow screens #93477

Open
jsha opened this issue Jan 30, 2022 · 0 comments
Open

rustdoc: wrap "source" link to new line on narrow screens #93477

jsha opened this issue Jan 30, 2022 · 0 comments
Assignees
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Jan 30, 2022

Following up #92861, where we let the out-of-band info (1.0.0 · source · [-]) move to a new line on narrow screens, we should give the same treatment to the individual source links next to methods and impl blocks. Note this will require a bit of a change in the DOM, to put the source links after the headings. Like the previous PR, we should set flex-wrap, so they can wrap on an individual basis as needed, plus a flex-direction: column in the mobile settings, so past a certain narrowness they always get wrapped.

@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jan 30, 2022
@jsha jsha changed the title rustdoc: wrap source to new line on narrow screens rustdoc: wrap "source" link to new line on narrow screens Jan 31, 2022
@jsha jsha self-assigned this Jan 31, 2022
@lolbinarycat lolbinarycat added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants