Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use copy_file_range(2) only on Linux >= 5.3 #86718

Closed
kubo39 opened this issue Jun 29, 2021 · 2 comments
Closed

Use copy_file_range(2) only on Linux >= 5.3 #86718

kubo39 opened this issue Jun 29, 2021 · 2 comments

Comments

@kubo39
Copy link
Contributor

kubo39 commented Jun 29, 2021

In case copy_file_rang(2), Linux's man page says:

A major rework of the kernel implementation occurred in 5.3.
Areas of the API that weren't clearly defined were clarified and
the API bounds are much more strictly checked than on earlier
kernels. Applications should target the behaviour and
requirements of 5.3 kernels.
First support for cross-filesystem copies was introduced in Linux
5.3. Older kernels will return -EXDEV when cross-filesystem
copies are attempted.

And at least Go's Issue shows that it's broken in CIFS.
I think it should be fixed like Go did.

@the8472
Copy link
Member

the8472 commented Jun 29, 2021

Is that issue not covered by the workaround in #75428?

@kubo39
Copy link
Contributor Author

kubo39 commented Jun 30, 2021

Ahh, sorry I should've looked into more deeply. I think this is covered by #75428 so close.

@kubo39 kubo39 closed this as completed Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants