Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Manual" crater run for edition migration #86691

Closed
nikomatsakis opened this issue Jun 28, 2021 · 3 comments
Closed

"Manual" crater run for edition migration #86691

nikomatsakis opened this issue Jun 28, 2021 · 3 comments
Assignees
Labels
A-edition-2021 Area: The 2021 edition T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

Before doing the public test, we should do a manual crater run. Here are the crates.io top-downloaded crates:

  • rand
  • syn
  • libc
  • rand_core
  • quote
  • unicode-xid
  • proc-macro2
  • cfg-if
  • serde
  • bitflags
@nikomatsakis nikomatsakis added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-edition-2021 Area: The 2021 edition labels Jun 28, 2021
@rylev
Copy link
Member

rylev commented Jun 30, 2021

Here is a running list of issues found in manual crater testing the edition migrations:

@rylev
Copy link
Member

rylev commented Jun 30, 2021

If you'd like to run this "mini" crater yourself, please take a look at my absolutely horrendous Ruby code here.

@rylev
Copy link
Member

rylev commented Jul 12, 2021

Closing this now as we've done the run and found some issues. I think we're unlikely to find more issues in this controlled path, and we should focus on the full crater run and public testing.

@rylev rylev closed this as completed Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-edition-2021 Area: The 2021 edition T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants