Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Re-exported macros 2.0 are rendered as macro_rules! #86276

Closed
camelid opened this issue Jun 13, 2021 · 3 comments · Fixed by #86841
Closed

rustdoc: Re-exported macros 2.0 are rendered as macro_rules! #86276

camelid opened this issue Jun 13, 2021 · 3 comments · Fixed by #86841
Assignees
@GuillaumeGomez
Labels
A-cross-crate-reexports Area: Documentation that has been re-exported from a different crate A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-macros-2.0 Area: Declarative macros 2.0 (#39412) C-bug Category: This is a bug. P-low Low priority requires-nightly This issue requires a nightly compiler in some way. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented Jun 13, 2021

I noticed this while working on a fix for #86208. I think the issue is just that clean/inline.rs does not check if the macro is a macro_rules!, whereas clean/mod.rs does.

core (original)

image

std (re-export)

image
@camelid camelid added A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-macros-2.0 Area: Declarative macros 2.0 (#39412) C-bug Category: This is a bug. A-cross-crate-reexports Area: Documentation that has been re-exported from a different crate T-rustdoc I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jun 13, 2021
@jyn514 jyn514 added requires-nightly This issue requires a nightly compiler in some way. I-prioritize Issue: Indicates that prioritization has been requested for this issue. and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jun 14, 2021
@camelid camelid self-assigned this Jun 14, 2021
@camelid
Copy link
Member Author

camelid commented Jun 14, 2021

Assigning myself because I'd like to look into this.

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed T-rustdoc-temp labels Jun 22, 2021
@apiraino
Copy link
Contributor

Assigning priority as discussed in the Zulip thread of the Prioritization Working Group.

@rustbot label -I-prioritize +P-low

@apiraino apiraino added P-low Low priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Jun 24, 2021
@GuillaumeGomez
Copy link
Member

Even though it's a low priority, it still remains a bug that needs to be fixed. I'll take it from here.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 3, 2021
Merged
@bors bors closed this as completed in 3a24abd Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-cross-crate-reexports Area: Documentation that has been re-exported from a different crate A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-macros-2.0 Area: Declarative macros 2.0 (#39412) C-bug Category: This is a bug. P-low Low priority requires-nightly This issue requires a nightly compiler in some way. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix rendering of reexported macros 2.0 and fix visibility of reexported items GuillaumeGomez/rust
4 participants
@GuillaumeGomez @apiraino @jyn514 @camelid