Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust OR_PATTERNS_BACK_COMPAT lint level #84869

Closed
ehuss opened this issue May 3, 2021 · 1 comment · Fixed by #86192
Closed

Adjust OR_PATTERNS_BACK_COMPAT lint level #84869

ehuss opened this issue May 3, 2021 · 1 comment · Fixed by #86192
Assignees
@Rustin170506
Labels
A-edition-2021 Area: The 2021 edition A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.

Comments

@ehuss
Copy link
Contributor

ehuss commented May 3, 2021 •
edited by rustbot
Loading

The OR_PATTERNS_BACK_COMPAT lint level should be adjusted for the 2021 edition. Either the lint should be warn-by-default always, or it should be a 2021 future-incompatible lint. This is needed to smoothly migrate projects to 2021.

There is some appeal to making it always warn for less confusion, as long as the lint works well. I think this course needs to be overridable via 2021 migration (see https://github.com/orgs/rust-lang/projects/7#card-59862192), and be aware that projects which support a wide range of rustc versions may be forced to allow it.
@ehuss ehuss added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-edition-2021 Area: The 2021 edition labels May 3, 2021
@Rustin170506
Copy link
Member

Rustin170506 commented May 3, 2021 •
edited
Loading

@rustbot claim

Maybe it should be a 2021 future-incompatible lint?

@Rustin170506 Rustin170506 mentioned this issue Jun 10, 2021
Merged
@bors bors closed this as completed in 3ee78b3 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rustin170506 Rustin170506

Labels
A-edition-2021 Area: The 2021 edition A-lints Area: Lints (warnings about flaws in source code) such as unused_mut.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make OR_PATTERNS_BACK_COMPAT be a 2021 future-incompatible lint Rustin170506/rust
2 participants
@ehuss @Rustin170506