Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing links to src of implementors in docs of hir and ast visitors #81190

Closed
b-naber opened this issue Jan 19, 2021 · 3 comments
Closed

Missing links to src of implementors in docs of hir and ast visitors #81190

b-naber opened this issue Jan 19, 2021 · 3 comments
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@b-naber
Copy link
Contributor

b-naber commented Jan 19, 2021

In the docs for the compiler no links to the source code of the implementors of the ast::Visitor and the hir::Visitor are provided. @jyn514 said that this is likely a bug.
@jyn514
Copy link
Member

jyn514 commented Jan 19, 2021

Related: #76736

@jyn514 jyn514 added A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 19, 2021
@camelid
Copy link
Member

camelid commented Jan 20, 2021

I believe this is a duplicate of #78615.

@jyn514
Copy link
Member

jyn514 commented Jan 21, 2021

Good catch, it is indeed a duplicate.

@jyn514 jyn514 closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jyn514 @camelid @b-naber