Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for worktrees to x.py setup git hook #77684

Closed
jyn514 opened this issue Oct 7, 2020 · 1 comment · Fixed by #77778
Closed

Add support for worktrees to x.py setup git hook #77684

jyn514 opened this issue Oct 7, 2020 · 1 comment · Fixed by #77778
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Oct 7, 2020

.git doesn't exist for worktrees. x.py setup should use git rev-parse --git-common-dir instead.

x.py encountered an error -- do you already have the git hook installed?
Not a directory (os error 20)

Originally posted by @jyn514 in #76356 (comment)
@jyn514 jyn514 added the A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself label Oct 7, 2020
@jyn514
Copy link
Member Author

jyn514 commented Oct 7, 2020

Actually maybe this shouldn't run at all for worktrees since it applies globally to all worktrees and everything else x.py setup does currently is local to a worktree ...

@jyn514 jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 7, 2020
@jyn514 jyn514 mentioned this issue Oct 10, 2020
Merged
@jyn514 jyn514 added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Oct 16, 2020
@bors bors closed this as completed in 24907f3 Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[x.py setup] Allow setting up git hooks from other worktrees jyn514/rust
1 participant
@jyn514