Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making htmldocck more specific #76942

Open
jyn514 opened this issue Sep 19, 2020 · 0 comments
Open

Consider making htmldocck more specific #76942

jyn514 opened this issue Sep 19, 2020 · 0 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Sep 19, 2020

Currently htmldocck allows the text in rustdoc tests to be shorter, but not longer than the expected test. So if the actual text were Option<T and you wrote Option<T>, it would fail the test. But if the actual were Option<T> and the expected were Option<T, it would pass the test.

This behavior is not super intuitive and seems like it could lead to false negatives where it didn't catch regressions. Rustdoc should consider changing it.

Originally posted by @jyn514 in #76934 (comment)
@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 19, 2020
@jyn514 jyn514 mentioned this issue Sep 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Manishearth @jyn514