Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support armv7-unknown-linux-gnueabi and armv7-unknown-linux-musleabi (soft-float variants) #63101

Closed
adrian-budau opened this issue Jul 29, 2019 · 2 comments · Fixed by #63107
Closed

Support armv7-unknown-linux-gnueabi and armv7-unknown-linux-musleabi (soft-float variants) #63101

adrian-budau opened this issue Jul 29, 2019 · 2 comments · Fixed by #63107
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-linux Operating system: Linux T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@adrian-budau
Copy link
Contributor

Currently for armv7 only the hardfloat variants (armv7-unknown-linux-gnueabihf and armv7-unknown-linux-musleabihf) are supported.

I'll try to open a pull request as this seems to be a small change.
@hellow554
Copy link
Contributor

Is there a reason you don't use the thumbv7*-* targets instead?

@jonas-schievink jonas-schievink added C-feature-request Category: A feature request, i.e: not implemented / a PR. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-linux Operating system: Linux labels Jul 29, 2019
@adrian-budau
Copy link
Contributor Author

None of those targets support the std. In particular I require only the armv7-unknown-linux-muselabi target, but I mentioned both because it makes sense.

And arm-unknown-linux-musleabi doesn't work because some instructions use the CP15 register which is disabled/does not exist on our hardware (it's not particularly clear for us).

@adrian-budau adrian-budau mentioned this issue Jul 29, 2019
Merged
@Centril Centril added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 29, 2019
Centril added a commit to Centril/rust that referenced this issue Aug 2, 2019
@Centril
Rollup merge of rust-lang#63107 - adrian-budau:master, r=alexcrichton
a2735a3 
Added support for armv7-unknown-linux-gnueabi/musleabi

Fixes rust-lang#63101

Some things that are not done and I hope someone can help me with:

* During the ci build of `armv7-unknown-linux-gnueabi` `openssl` must be built (to build cargo) but `openssl` does not yet support this target. This feels slightly like a chicken-and-egg problem, any feedback is welcome.
* Should I add any tests for any of these targets?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. O-Arm Target: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state O-linux Operating system: Linux T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for armv7-unknown-linux-gnueabi/musleabi adrian-budau/rust
4 participants
@Centril @hellow554 @adrian-budau @jonas-schievink