Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue triage: closures, lifetimes, and nll #57964

Closed
17 tasks done
memoryruins opened this issue Jan 29, 2019 · 6 comments
Closed
17 tasks done

issue triage: closures, lifetimes, and nll #57964

memoryruins opened this issue Jan 29, 2019 · 6 comments
Assignees
Labels
A-closures Area: Closures (`|…| { … }`) A-lifetimes Area: Lifetimes / regions A-NLL Area: Non-lexical lifetimes (NLL) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. metabug Issues about issues themselves ("bugs about bugs") T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@memoryruins
Copy link
Contributor

memoryruins commented Jan 29, 2019

Most of the issues listed below appear ready to be closed or tagged. The check boxes are there to mark after a decision has been made on their respective threads (including if an issue is decided to be left open).

@pnkfelix @matthewjasper mind checking these out? what started as a general triage, ended up accumulating a bit of fixed-by-nll issues. although not all nll-related, the other issues are generally in areas you could help make a final decision on.

now compiles on both editions

rustc: 1.32.0

The following issues previously did not compile.
These appear ready to close, unless if any need a test.

now compiles on 2018

rustc: 1.32.0

cc @rust-lang/wg-compiler-nll

The following issues previously did not compile, but now do on 2018.
They also compile on 2015 with#![feature(nll)].

now compiles on beta / nightly on both editions

rust version 1.34.0-nightly (da6ab956e 2019-01-27)

needs test?

now (correctly) rejected on beta / nightly on both editions

These appear ready to close, unless if any need a test.

@Centril Centril added A-lifetimes Area: Lifetimes / regions A-closures Area: Closures (`|…| { … }`) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-NLL Area: Non-lexical lifetimes (NLL) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels Jan 29, 2019
@memoryruins
Copy link
Contributor Author

memoryruins commented Jan 30, 2019

I've begun to comment on the individual issues with the updates and errors, as well as tagging fixed-by-nll where it seems fit (edit: I mistakenly / prematurely tagged a few as fixed-by-nll in the list, so I removed a few tags; there might be a few others to remove). Removed #30127 and #48677 from the list because they still error on 2018 when used.

@pnkfelix
Copy link
Member

@memoryruins I believe our policy is indeed to leave issues tagged with NLL-fixed-by-NLL open, since the old borrow-checker is still on by default in the 2015 edition.

When we turn NLL on for the 2015 edition (#57804) then we will be able to start closing the NLL-fixed-by-NLL issues.

@pnkfelix
Copy link
Member

tagging as metabug.

In general most of these issues are tagged NLL-fixed-by-NLL and so they'll tend to stay open until #57804 is addressed. Which means I don't see much point in trying to assign high priority to this issue (since most of the work items cannot be addressed until #57804 is addressed.)

@pnkfelix pnkfelix added the metabug Issues about issues themselves ("bugs about bugs") label Feb 27, 2019
@pnkfelix
Copy link
Member

pnkfelix commented Jul 9, 2019

Hey lets start closing some of these that are fixed now that NLL is on for all editions in stable!

@pnkfelix
Copy link
Member

pnkfelix commented Jul 9, 2019

oh wait: we cannot close the ones that correspond to errors-downgraded-to-warnings I think, because most of those are soundness issues, and we probably need to wait until we stop the downgrading-to-warnings before we close all those issues. 😢

@crlf0710
Copy link
Member

@pnkfelix #30786 has test added in #62519 Maybe we can tick the last box... and maybe close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-closures Area: Closures (`|…| { … }`) A-lifetimes Area: Lifetimes / regions A-NLL Area: Non-lexical lifetimes (NLL) C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. metabug Issues about issues themselves ("bugs about bugs") T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants