Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dead_code lint not running on code generated by crate-external macros #53209

Open
KodrAus opened this issue Aug 8, 2018 · 1 comment
Open
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut.

Comments

@KodrAus
Copy link
Contributor

KodrAus commented Aug 8, 2018

We've hit a bit of a snag in rust-lang-nursery/lazy-static.rs#110 where it looks like the dead_code lint for code generated by the lazy_static macro in external crates isn't being triggered and is causing one of our compilefail tests to start building instead of failing.

I'm just trying to track down what we changed here in the compiler to get some context about how we should approach the issue in lazy_static. We can probably live with warnings not being surfaced if there's some bigger picture around the change. I may also be totally off in the weeds on this.

EDIT: The change was somewhere between 12ed235 and 6a1c063

@persytry
Copy link

persytry commented Apr 5, 2023

Is the Issue resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut.
Projects
None yet
Development

No branches or pull requests

3 participants