Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suites of xml-rs and quick-xml crates fails on 1.28 beta #51843

Closed
pietroalbini opened this issue Jun 27, 2018 · 6 comments
Closed

Test suites of xml-rs and quick-xml crates fails on 1.28 beta #51843

pietroalbini opened this issue Jun 27, 2018 · 6 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone
1.28

Comments

@pietroalbini
Copy link
Member

I think that's caused by a change in the debug repr, but I haven't bisected/checked.
@pietroalbini pietroalbini added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Jun 27, 2018
@pietroalbini pietroalbini added this to the 1.28 milestone Jun 27, 2018
@tomaka
Copy link
Contributor

tomaka commented Jun 27, 2018

cc @netvl

@Mark-Simulacrum
Copy link
Member

65a16c0 -- #49283 -- cc @rust-lang/libs

Looks like an intentional change though.

@pietroalbini pietroalbini added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 27, 2018
@pietroalbini
Copy link
Member Author

FYI, there was a similar regression in a past release (#47619), and this was the decision:

@sfackler - #47619 (comment)
We make zero guarantees as to what Debug implementations look like.

@SimonSapin
Copy link
Contributor

This was indeed intentional, and I support the quoted comment about the lack of guarantee.

@Mark-Simulacrum
Copy link
Member

Okay, I'm going to close as this isn't something we're going to fix.

@tafia tafia mentioned this issue Jul 9, 2018
Merged
@tafia
Copy link
Contributor

tafia commented Jul 9, 2018

Just fyi, quick-xml tests are no longer relying on Debug format. They all use Display only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.28
Development

No branches or pull requests
5 participants
@SimonSapin @tomaka @pietroalbini @Mark-Simulacrum @tafia