Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

it rebuilds "stage0 tool compiletest" even if you only change the compiler #50060

Closed
est31 opened this issue Apr 18, 2018 · 0 comments
Closed

it rebuilds "stage0 tool compiletest" even if you only change the compiler #50060

est31 opened this issue Apr 18, 2018 · 0 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Apr 18, 2018

Do the following: ./x.py test --stage 1 src/test/run-pass --test-gs i128

Then change something in the compiler, e.g. a comment in librustc.

Then invoke the command again. You'll see that not just the compiler but also compiletest is being recompiled even though it doesn't have to.

cc @Mark-Simulacrum
@csmoe csmoe added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Apr 19, 2018
@est31 est31 mentioned this issue May 6, 2018
Merged
@XAMPPRocky XAMPPRocky added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 27, 2018
@est31 est31 closed this as completed Oct 19, 2018
@rust-lang rust-lang locked and limited conversation to collaborators Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@XAMPPRocky @est31 @csmoe