Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto_encode should probably pass fully-qualified type- and enum-names #4872

Closed
jbclements opened this issue Feb 10, 2013 · 3 comments
Closed
Labels
A-syntaxext Area: Syntax extensions

Comments

@jbclements
Copy link
Contributor

Per discussion w/ @nmatsakis , the auto_encode framework should probably make calls to the encoder with fully-qualified type- and enum-names. So, for instance, the "name" field in a Some(13) would not be "Some", but rather core::option::Option (or perhaps ::core::option::Option). A similar alternative would be to pass a path along with the name.

I'm creating this issue for use in a FIXME note in the source.

@bstrie
Copy link
Contributor

bstrie commented Jun 26, 2013

I can't find the FIXME in question any more. @erickt, is this done?

@catamorphism
Copy link
Contributor

Re-nominating for milestone 5, production-ready -- unless this is actually done?

@alexcrichton
Copy link
Member

This FIXME does not appear to be present, nor does auto_encode exist any more (it now manifests itself as deriving(Encodable)).

I'm not entirely sure that we're even still passing around type names in these. This may be more relevant with repr-type things, but @thestinger changed that recently to print full-qualified type names anyway.

From that, I'm gonna go ahead and close this, if others feel different though, feel free to reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-syntaxext Area: Syntax extensions
Projects
None yet
Development

No branches or pull requests

4 participants