Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing_debug_implementations misses structs exported from other crates #44304

Closed
clarfonthey opened this issue Sep 3, 2017 · 1 comment
Closed

missing_debug_implementations misses structs exported from other crates #44304

clarfonthey opened this issue Sep 3, 2017 · 1 comment
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@clarfonthey
Copy link
Contributor

clarfonthey commented Sep 3, 2017 •
edited
Loading

For example, std::str::SplitWhitespace does not have a debug implementation (see: PR #44303), but the lint didn't trigger. I'd consider this a bug; if there isn't a debug implementation for an exported struct, the user should have to put allow(missing_debug_implementations) to suppress it if they can't fix it themself.

This probably applies to missing_docs too.
@alexcrichton alexcrichton added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 7, 2017
@TimNN TimNN added the A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. label Sep 17, 2017
@Enselic
Copy link
Member

Enselic commented Sep 26, 2023

Triage: As far as I know, it is a widely accepted policy to not lint on code that does not belong to the compiled crate, since the code in dependencies can't be changed (without significant effort like forking or contributing a fix). So I'll go ahead and close this as won't fix. If you still want to try to change this I would recommend going the RFC route.

@Enselic Enselic closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lint Area: Lints (warnings about flaws in source code) such as unused_mut. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexcrichton @Enselic @TimNN @clarfonthey