Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rulinalg-0.3.7 beta regression #43678

Closed
est31 opened this issue Aug 5, 2017 · 3 comments
Closed

rulinalg-0.3.7 beta regression #43678

est31 opened this issue Aug 5, 2017 · 3 comments
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@est31
Copy link
Member

est31 commented Aug 5, 2017

rulinalg version 0.3.7 regressed from stable to beta (full log):

Aug 03 18:40:40.613 INFO blam! ---- src/macros/matrix_eq.rs - assert_matrix_eq (line 501) stdout ----
Aug 03 18:40:40.613 INFO blam! 	error: type `rulinalg::macros::matrix_eq::AbsoluteError<f64>` is private
Aug 03 18:40:40.613 INFO blam!  --> <anon>:6:1
Aug 03 18:40:40.613 INFO blam!   |
Aug 03 18:40:40.613 INFO blam! 6 | assert_matrix_eq!(x, y, comp = abs, tol = 1e-12);
Aug 03 18:40:40.613 INFO blam!   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Aug 03 18:40:40.613 INFO blam!   |
Aug 03 18:40:40.613 INFO blam!   = note: this error originates in a macro outside of the current crate
Aug 03 18:40:40.613 INFO blam! 

cc @AtheMathmo

@arielb1
Copy link
Contributor

arielb1 commented Aug 5, 2017

This struct needs to be made public: https://github.com/AtheMathmo/rulinalg/blob/bd67aa6510cc98083be1f7accc33d0ffcf96d8e9/src/macros/matrix_eq.rs#L303

Note: it is made public in upstream, but is still broken in 0.4.2, which is the most recent crates.io release.

@arielb1 arielb1 added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2017
@AtheMathmo
Copy link
Contributor

Thank you for letting me know. I've been lagging behind on updates for rulinalg. I'll push a new version with this fix today!

@Mark-Simulacrum Mark-Simulacrum added the C-bug Category: This is a bug. label Aug 10, 2017
@alexcrichton
Copy link
Member

I believe the compiler/lang teams won't be reverting #42125, so I'm going to close this regression tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants