Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builders to verify that packaging rust in a typical configuration works #42786

Closed
Mark-Simulacrum opened this issue Jun 21, 2017 · 4 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Jun 21, 2017

This is intended to prevent issues such as #42543. Ideally, we would run this as a Travis bot -- probably doesn't need to run tests, but uncertain.

Specifically, --enable-local-rust.

@Mark-Simulacrum Mark-Simulacrum added I-nominated P-high High priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jun 21, 2017
@Mark-Simulacrum Mark-Simulacrum changed the title Verify that bootstrapping from previous stable works Add builders to verify that packaging rust in a typical configuration works Jun 21, 2017
@est31
Copy link
Member

est31 commented Jun 21, 2017

In such an environment, we should also make sure that we don't have network access, to prevent bugs like #42719.

@Mark-Simulacrum
Copy link
Member Author

Discussed during meeting: We think this is generally a good idea but specifics need to be worked out. Right now, our plan is to ask some distro (perhaps debian) for their configuration and test that stage0 bootstrap works with it. cc @alexcrichton

@Mark-Simulacrum Mark-Simulacrum added C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority and removed P-high High priority labels Jul 27, 2017
@est31
Copy link
Member

est31 commented Dec 20, 2017

One can apparently turn off network access via unshare: rust-lang/cargo#4770 (comment)

@Mark-Simulacrum
Copy link
Member Author

We discussed this some more today and generally decided that we don't believe this is too viable to do today and is likely not too beneficial in general. We may revisit this in a more targeted manner later down the line (after CI migration concludes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. P-medium Medium priority T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants