Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0184 needs to be updated to new format #35275

Closed
sophiajt opened this issue Aug 3, 2016 · 2 comments
Closed

E0184 needs to be updated to new format #35275

sophiajt opened this issue Aug 3, 2016 · 2 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

From: src/test/compile-fail/E0184.rs

Error E0184 needs a span_label, updating it from:

error[E0184]: the trait `Copy` may not be implemented for this type; the type has a destructor
  --> src/test/compile-fail/E0184.rs:11:10
   |
11 | #[derive(Copy)] //~ ERROR E0184
   |          ^^^^
src/test/compile-fail/E0184.rs:11:10: 11:14 note: in this expansion of #[derive(Copy)] (defined in src/test/compile-fail/E0184.rs)

To:

error[E0184]: the trait `Copy` may not be implemented for this type; the type has a destructor
  --> src/test/compile-fail/E0184.rs:11:10
   |
11 | #[derive(Copy)] //~ ERROR E0184
   |          ^^^^ Copy not allowed on types with destructors
src/test/compile-fail/E0184.rs:11:10: 11:14 note: in this expansion of #[derive(Copy)] (defined in src/test/compile-fail/E0184.rs)

Bonus: I'm not sure that note is helping, you can probably just remove it.

@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 3, 2016
@yossi-k
Copy link
Contributor

yossi-k commented Aug 4, 2016

On it

@sophiajt
Copy link
Contributor Author

@yossi-k - I am releasing this one so someone else can take it, but feel free to come grab another one

@bors bors closed this as completed in 2967dcc Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants