Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E0118 needs to be updated to new format #35251

Closed
sophiajt opened this issue Aug 3, 2016 · 1 comment
Closed

E0118 needs to be updated to new format #35251

sophiajt opened this issue Aug 3, 2016 · 1 comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.

Comments

@sophiajt
Copy link
Contributor

sophiajt commented Aug 3, 2016

From: src/test/compile-fail/E0118.rs

Error E0118 needs a span_label and a span_note to be a simple note, updating from:

error[E0118]: no base type found for inherent implementation
  --> src/test/compile-fail/E0118.rs:11:1
   |
11 | impl (u8, u8) { //~ ERROR E0118
   | ^
   |
help: either implement a trait on it or create a newtype to wrap it instead
  --> src/test/compile-fail/E0118.rs:11:1
   |
11 | impl (u8, u8) { //~ ERROR E0118
   | ^

To:

error[E0118]: no base type found for inherent implementation
  --> src/test/compile-fail/E0118.rs:11:1
   |
11 | impl (u8, u8) { //~ ERROR E0118
   | ^ impl requires a base type
   |
   = note: either implement a trait on it or create a newtype to wrap it instead

Bonus: It'd be good if we could underline the type it's complaining about.

error[E0118]: no base type found for inherent implementation
  --> src/test/compile-fail/E0118.rs:11:1
   |
11 | impl (u8, u8) { //~ ERROR E0118
   |      ^^^^^^^^ impl requires a base type
   |
   = note: either implement a trait on it or create a newtype to wrap it instead
@sophiajt sophiajt added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-diagnostics Area: Messages for errors, warnings, and lints E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion. labels Aug 3, 2016
@Detegr
Copy link
Contributor

Detegr commented Aug 4, 2016

In case no one is working with this yet, I can give this a go.

@bors bors closed this as completed in e91f3f6 Aug 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-mentor Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Projects
None yet
Development

No branches or pull requests

2 participants