Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: unclear stability state of tracking issues for RFCs #32826

Closed
pnkfelix opened this issue Apr 8, 2016 · 2 comments
Closed

meta: unclear stability state of tracking issues for RFCs #32826

pnkfelix opened this issue Apr 8, 2016 · 2 comments

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Apr 8, 2016

While reviewing the situation of #15701, I realized that I don't actually know when one is supposed to close a tracking issue.

Is it supposed to happen when:

  • the feature has an initial feature-gated potentially-broken implementation, or
  • a "complete" non-broken but still feature-gated implementation, or
  • the feature is stabilized?

(or something else?)

From reviewing a semi-randomly selected set of RFC's, I don't think we have a consistent policy here.

The most reliable thing that I noted is that if the label:B-unstable is present (on open or closed issues), then that implies that the feature is unstable; but that is not a bi-directional implication.

This ticket is meant to suggest we take three steps:

  1. Establish what the actual policy is here,
  2. Update the existing tickets to reflect that policy, and
  3. Document that policy somewhere (perhaps in the RFC process document).

Since this is largely about meta-administrative issues of the rust-lang/rust repo, I have filed the issue there. But its possible the core team will determine that this actually belongs as a first class RFC (or RFC amendment) of its own...

@alexcrichton
Copy link
Member

For the libs team our policy is basically:

  1. After an RFC is accepted, open a B-RFC-accepted issue
  2. After it's implemented, change the same issue to B-unstable
  3. When stabilized or deprecated to be removed, close the issue

That... may not be written down though, and it may not also apply to historical or lang issues perhaps.

@brson
Copy link
Contributor

brson commented Mar 1, 2017

I've just gone through and tagged a bunch of stuff B-unstable, though I was not thinking about whether they had actually been implemented yet. Oops. Anyway, @alexcrichton's response seems to be how it works.

@brson brson closed this as completed Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants