Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-export core::priv when uv moves to core. #2648

Closed
graydon opened this issue Jun 20, 2012 · 1 comment
Closed

Un-export core::priv when uv moves to core. #2648

graydon opened this issue Jun 20, 2012 · 1 comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@graydon
Copy link
Contributor

graydon commented Jun 20, 2012

See fixme in file. core::priv shouldn't be exported.
This was referenced Aug 7, 2012
Closed
Closed
@bblum
Copy link
Contributor

bblum commented Aug 21, 2012

see rationale on #3144 for why this wasn't done.

@bblum bblum closed this as completed in 0229bc4 Aug 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@graydon @bblum