Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::io::prelude should stop renaming Seek #23378

Closed
lilyball opened this issue Mar 15, 2015 · 1 comment · Fixed by #23470
Closed

std::io::prelude should stop renaming Seek #23378

lilyball opened this issue Mar 15, 2015 · 1 comment · Fixed by #23470
Milestone
1.0 beta

Comments

@lilyball
Copy link
Contributor

std::io::prelude currently re-exports std::io::Seek as NewSeek. This should be changed before 1.0, as the renaming only makes sense in light of the old_io migration, and old_io is now deprecated. std::io::prelude is already declared stable, but I think that was a mistake and we should just go ahead and modify it.

This is related to #23377 (std::prelude::v1 still re-exports std::old_io::Seek).

/cc @alexcrichton
@alexcrichton alexcrichton mentioned this issue Mar 18, 2015
Merged
@pnkfelix
Copy link
Member

1.0 beta, P-backcompat-libs. ( @alexcrichton says there's a PR in the queue.)

@pnkfelix pnkfelix added this to the 1.0 beta milestone Mar 19, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this issue Mar 21, 2015
@alexcrichton
std: Remove old_io/old_path from the prelude
212e031 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes rust-lang#23377
Closes rust-lang#23378
bors added a commit that referenced this issue Mar 21, 2015
@bors
Auto merge of #23470 - alexcrichton:less-prelude, r=aturon
ecf8c64 
This commit removes the reexports of `old_io` traits as well as `old_path` types
and traits from the prelude. This functionality is now all deprecated and needs
to be removed to make way for other functionality like `Seek` in the `std::io`
module (currently reexported as `NewSeek` in the io prelude).

Closes #23377
Closes #23378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 beta
Development

Successfully merging a pull request may close this issue.

std: Remove old_io/old_path from the prelude alexcrichton/rust
2 participants
@lilyball @pnkfelix