Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caching and other optimizations for method call resolution #18716

Closed
nikomatsakis opened this issue Nov 6, 2014 · 5 comments
Closed

Caching and other optimizations for method call resolution #18716

nikomatsakis opened this issue Nov 6, 2014 · 5 comments
Assignees
@nikomatsakis
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nikomatsakis
Copy link
Contributor

Method call resolution takes a long time. It should not.
@nikomatsakis nikomatsakis self-assigned this Nov 6, 2014
@nikomatsakis
Copy link
Contributor Author

This PR lays groundwork to support caching: #18694

@pcwalton also had a clever idea for quick-reject, which could be rebased on top of that PR: #17995

@steveklabnik
Copy link
Member

Triage: unsure if this has been implemented or not.

@nikomatsakis
Copy link
Contributor Author

No.

@Mark-Simulacrum Mark-Simulacrum added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. I-compiletime Issue: Problems and improvements with respect to compile times. and removed I-papercut labels Jul 22, 2017
@ishitatsuyuki
Copy link
Contributor

It has been a long time since this issue have been around. @nikomatsakis Is this still a thing we should do?

@nikomatsakis
Copy link
Contributor Author

Hmm. I think we can go ahead and close. We've got quick reject and we're using trait evaluation, which has a cache. There is probably still more caching that could be done but it's not where I would start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikomatsakis nikomatsakis

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. I-compiletime Issue: Problems and improvements with respect to compile times. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @nikomatsakis @Mark-Simulacrum @ishitatsuyuki