Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for checking the glibc version required by rustc #134037

Open
Kobzol opened this issue Dec 8, 2024 · 0 comments · May be fixed by #135164
Open

Add tests for checking the glibc version required by rustc #134037

Kobzol opened this issue Dec 8, 2024 · 0 comments · May be fixed by #135164
Assignees
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Dec 8, 2024

We promise that our GNU rustc toolchains won't need a glibc newer than a certain version (https://blog.rust-lang.org/2022/08/01/Increasing-glibc-kernel-requirements.html), but we don't currently have a test that would actually test this. It can be quite easy to inadvertedly bump the glibc, for example when updating base images of the OS in a container that builds the dist toolchain on CI.

It would be nice of we had some kind of (run-make?) test that checks the exact version of glibc used by a toolchain compiled on CI. It should be executed explicitly in specific CI runners, so that we can vary the required glibc version per CI job (and thus per tier/platform).

@Kobzol Kobzol added the A-testsuite Area: The testsuite used to check the correctness of rustc label Dec 8, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 8, 2024
@jieyouxu jieyouxu added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-enhancement Category: An issue proposing an enhancement or a PR with one. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Dec 9, 2024
@onur-ozkan onur-ozkan added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Dec 9, 2024
@Kobzol Kobzol self-assigned this Jan 6, 2025
@Kobzol Kobzol linked a pull request Jan 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants