Deny special FileCheck prefixes being used as revision names. #130982
Labels
A-compiletest
Area: The compiletest test runner
C-bug
Category: This is a bug.
E-medium
Call for participation: Medium difficulty. Experience needed to fix: Intermediate.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
FileCheck expects directives like:
compiletest supports
//@ revisions: a b c
and passes the revision names as--check-prefixes=a,b,c
to FileCheck. They look likeHowever, FileCheck has special default/reserved prefixes like
CHECK
orCOM
, and if the test writer uses those as revision names, it becomes really confusing://@ revisions: CHECK COM
. We should deny those.Also we should deny
NEXT
,SAME
,EMPTY
,NOT
,COUNT
,DAG
andLABEL
, becauseis equally confusing.
Related to:
The text was updated successfully, but these errors were encountered: