Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for release notes of #128316: Stabilize most of io_error_more #131396

Closed
3 tasks
rustbot opened this issue Oct 8, 2024 · 4 comments
Closed
3 tasks
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@rustbot
Copy link
Collaborator

rustbot commented Oct 8, 2024

This issue tracks the release notes text for #128316.

Steps

  • Proposed text is drafted by PR author (or team) making the noteworthy change.
  • Issue is nominated for release team review of clarity for wider audience.
  • Release team includes text in release notes/blog posts.

Release notes text

The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).

# Category (e.g. Language, Compiler, Libraries, Compatibility notes, ...)
- [Stabilize most of `io_error_more`](https://github.com/rust-lang/rust/pull/128316)

Tip

Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.

More than one section can be included if needed.

Release blog section

If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.

cc @GrigorenkoPV, @dtolnay -- origin issue/PR authors and assignees for starting to draft text

@rustbot rustbot added relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Oct 8, 2024
@rustbot rustbot added this to the 1.83.0 milestone Oct 8, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 8, 2024
@GrigorenkoPV
Copy link
Contributor

From what I can tell, this should be just closed, because it's simply API stabilization: #130825 (comment)

@rustbot close

(Probably don't have enough rights for that)

@rustbot
Copy link
Collaborator Author

rustbot commented Oct 8, 2024

Error: The feature close is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@dtolnay dtolnay closed this as completed Oct 8, 2024
@jieyouxu jieyouxu removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 10, 2024
@joboet
Copy link
Member

joboet commented Oct 15, 2024

Correct me if I'm wrong, but shouldn't release tracking issues stay open until the change has actually been included in the release notes?

@joboet joboet reopened this Oct 15, 2024
ericcornelissen added a commit to ericcornelissen/rust-rm that referenced this issue Oct 19, 2024
Upgrade the version of Rust and related tooling from 1.81.0 to 1.82.0,
which was recently released [1]. Additionally, this sets the version in
the project manifest (Cargo.toml) for completeness (found via the new
`cargo info` command).

The `io_error_more` gate is still applicable - verified based on the
corresponding GitHub issue and running the tests with the related code
removed. However, it seems 1.83 will be the end of this, see [2].

For the update to Clippy, two new rules from the "Restrictions" group
were explicitly enabled as they're relevant to this project. I also re-
evaluated the allow directive for the `ignore_unit_patterns` lint and
decided to just refactor the codebase in line with the lint instead
(it was allowed in 44b36a5 originally,
based on the reason given there I *guess* the noisiness has been reduced
by Clippy in the meanwhile).

Lastly, this fixes a problem in the ephemeral development environment
where some `just` commands would fail because git did not recognize the
working directory as trusted. This has been addressed by telling git to
trust it.

--
1. https://blog.rust-lang.org/2024/10/17/Rust-1.82.0.html
2. rust-lang/rust#131396
ericcornelissen added a commit to ericcornelissen/rust-rm that referenced this issue Oct 19, 2024
Upgrade the version of Rust and related tooling from 1.81.0 to 1.82.0,
which was recently released [1]. Additionally, this sets the version in
the project manifest (Cargo.toml) for completeness (found via the new
`cargo info` command).

The `io_error_more` gate is still applicable - verified based on the
corresponding GitHub issue and running the tests with the related code
removed. However, it seems 1.83 will be the end of this, see [2].

For the update to Clippy, two new rules from the "Restrictions" group
were explicitly enabled as they're relevant to this project. I also re-
evaluated the allow directive for the `ignore_unit_patterns` lint and
decided to just refactor the codebase in line with the lint instead
(it was allowed in 44b36a5 originally,
based on the reason given there I *guess* the noisiness has been reduced
by Clippy in the meanwhile).

Lastly, this fixes a problem in the ephemeral development environment
where some `just` commands would fail because git did not recognize the
working directory as trusted. This has been addressed by telling git to
trust it.

--
1. https://blog.rust-lang.org/2024/10/17/Rust-1.82.0.html
2. rust-lang/rust#131396
@cuviper
Copy link
Member

cuviper commented Nov 22, 2024

This is included in "Stabilized APIs", so it doesn't need its own relnotes entry.

(We create that list from since attributes, so the tracking issue isn't adding anything.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. relnotes-tracking-issue Marks issues tracking what text to put in release notes. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants