Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: toolbar redesign no longer properly handles shortening of long crate names in search dropdown #130993

Closed
steffahn opened this issue Sep 28, 2024 · 3 comments · Fixed by #131002
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Comments

@steffahn
Copy link
Member

Last time I contributed to the design of the crate selection, which was merged with the following PR

I made sure to test the handling of long crate names.

[CLICK TO EXPAND comparison screenshots with the old design]

Old Design:
Image
What happens with a long crate name:
Image

With the new design

the behavior seems a lot worse now:

[CLICK TO EXPAND comparison screenshots with the new design]

New Design:
Image
What happens with a long crate name:
Image

(Refer to the last screenshot above for the following description.)

In particular, I’m noticing that the button grows too large, shifts down a little but for some reason, and then pushes the Settings/Help/Summary control elements off-screen.

I don’t recall off the top of my head the specific HTML/CSS foo that used made this work in the first place, but possible it’s a relatively simple fix.

cc @GuillaumeGomez, @notriddle

@steffahn steffahn added the C-bug Category: This is a bug. label Sep 28, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 28, 2024
@GuillaumeGomez
Copy link
Member

Good catch! Want to send a fix? Otherwise I'll likely do it tomorrow or monday.

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 28, 2024
@steffahn
Copy link
Member Author

@GuillaumeGomez I don’t think I have too much motivation to get into learning how to use the testing framework this time around, either.

“allow edits by maintainers” is turned on in #131002, so feel free to take over the step of adding appropriate changes to the tests there, and/or point out test failures that are uncovering any actual issues with the PR, which I’d be happy to address.

@GuillaumeGomez
Copy link
Member

No problem, thanks for writing the fix. I'll put together the testing part tomorrow.

@bors bors closed this as completed in 0d6e130 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
3 participants