Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for RFC 3621: derive(CoercePointee) #123430

Open
1 of 6 tasks
traviscross opened this issue Apr 3, 2024 · 2 comments
Open
1 of 6 tasks

Tracking issue for RFC 3621: derive(CoercePointee) #123430

traviscross opened this issue Apr 3, 2024 · 2 comments
Labels
B-experimental Blocker: In-tree experiment; RFC pending, not yet approved or unneeded. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-derive_coerce_pointee Feature: RFC 3621's oft-renamed implementation S-tracking-impl-incomplete Status: The implementation is incomplete. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@traviscross
Copy link
Contributor

traviscross commented Apr 3, 2024 •
edited by workingjubilee
Loading

This is a tracking issue for #[derive(CoercePointee)].

The feature gate for the issue is #![feature(derive_coerce_pointee)].

It was formerly known as:

  • #[derive(UnsizeInner)]
  • #[derive(SmartPtr)]
  • #[feature(derive_smart_pointer)]

About tracking issues

Tracking issues are used to record the overall progress of implementation. They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions. A tracking issue is however not meant for large scale discussion, questions, or bug reports about a feature. Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.

Steps

Unresolved Questions

Related
@traviscross traviscross added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Apr 3, 2024
@traviscross traviscross changed the title Tracking Issue for derive(SmartPtr) Tracking Issue for derive(SmartPointer) Apr 3, 2024
@ojeda ojeda mentioned this issue Apr 3, 2024
Open
90 tasks
@fmease fmease added B-experimental Blocker: In-tree experiment; RFC pending, not yet approved or unneeded. S-tracking-unimplemented Status: The feature has not been implemented. labels Apr 3, 2024
wedsonaf added a commit to wedsonaf/rust that referenced this issue Apr 4, 2024
@wedsonaf
WIP: PoC for derive(SmartPointer)
bc0b0ad 
Tracking issue: rust-lang#123430
@wedsonaf wedsonaf mentioned this issue Apr 4, 2024
Closed
@traviscross traviscross added the F-derive_coerce_pointee Feature: RFC 3621's oft-renamed implementation label Apr 4, 2024
wedsonaf added a commit to wedsonaf/rust that referenced this issue Apr 11, 2024
@wedsonaf
WIP: PoC for derive(SmartPointer)
287afa7 
Tracking issue: rust-lang#123430
@Darksonn Darksonn mentioned this issue May 2, 2024
Merged
@dingxiangfei2009 dingxiangfei2009 mentioned this issue May 26, 2024
Merged
@traviscross traviscross added S-tracking-impl-incomplete Status: The implementation is incomplete. and removed S-tracking-unimplemented Status: The feature has not been implemented. labels May 27, 2024
compiler-errors added a commit to compiler-errors/rust that referenced this issue Jun 24, 2024
@compiler-errors
Rollup merge of rust-lang#125575 - dingxiangfei2009:derive-smart-ptr,…
ed460d2 
… r=davidtwco

SmartPointer derive-macro

<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r​? <reviewer name>
-->

Possibly replacing rust-lang#123472 for continued upkeep of the proposal rust-lang/rfcs#3621 and implementation of the tracking issue rust-lang#123430.

cc `@Darksonn` `@wedsonaf`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jun 24, 2024
@rust-timer
Unrolled build for rust-lang#125575
8a6bce8 
Rollup merge of rust-lang#125575 - dingxiangfei2009:derive-smart-ptr, r=davidtwco

SmartPointer derive-macro

<!--
If this PR is related to an unstable feature or an otherwise tracked effort,
please link to the relevant tracking issue here. If you don't know of a related
tracking issue or there are none, feel free to ignore this.

This PR will get automatically assigned to a reviewer. In case you would like
a specific user to review your work, you can assign it to them by using

    r​? <reviewer name>
-->

Possibly replacing rust-lang#123472 for continued upkeep of the proposal rust-lang/rfcs#3621 and implementation of the tracking issue rust-lang#123430.

cc `@Darksonn` `@wedsonaf`
@dingxiangfei2009 dingxiangfei2009 mentioned this issue Jul 3, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Jul 4, 2024
@matthiaskrgr
Rollup merge of rust-lang#127283 - dingxiangfei2009:check-repr-transp…
d27136f 
…arent, r=davidtwco

Reject SmartPointer constructions not serving the purpose

Tracking issue: rust-lang#123430

With this PR we will reject a row of malformed `SmartPointer` implementor candidates.

cc `@Darksonn` `@davidtwco` for context.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jul 4, 2024
@rust-timer
Unrolled build for rust-lang#127283
4222111 
Rollup merge of rust-lang#127283 - dingxiangfei2009:check-repr-transparent, r=davidtwco

Reject SmartPointer constructions not serving the purpose

Tracking issue: rust-lang#123430

With this PR we will reject a row of malformed `SmartPointer` implementor candidates.

cc `@Darksonn` `@davidtwco` for context.
@Kixunil

This comment was marked as resolved.

Sign in to view
@traviscross
Copy link
Contributor Author

@Kixunil: If you could, please file that as a separate issue (and reference this tracking issue from it).

@Kixunil Kixunil mentioned this issue Jul 12, 2024
Closed
@oli-obk oli-obk mentioned this issue Aug 1, 2024
Closed
@Brezak Brezak mentioned this issue Aug 6, 2024
Merged
@traviscross traviscross mentioned this issue Aug 14, 2024
Closed
@Darksonn Darksonn mentioned this issue Aug 23, 2024
Closed
@traviscross traviscross changed the title Tracking Issue for derive(SmartPointer) Tracking Issue for derive(UnsizeInner) Oct 2, 2024
@traviscross traviscross changed the title Tracking Issue for derive(UnsizeInner) Tracking issue for RFC 3621: derive(UnsizeInner) Oct 2, 2024
@traviscross traviscross changed the title Tracking issue for RFC 3621: derive(UnsizeInner) Tracking issue for RFC 3621: derive(SmartPtr) Oct 3, 2024
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Oct 7, 2024
@workingjubilee
Rollup merge of rust-lang#128721 - Brezak:pointee-in-strange-places, …
bd2e7ee 
…r=pnkfelix

Don't allow the `#[pointee]` attribute where it doesn't belong

Error if the `#[pointee]` attribute is applied to anything but generic type parameters.

Closes rust-lang#128485
Related to rust-lang#123430
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Oct 7, 2024
@rust-timer
Unrolled build for rust-lang#128721
a31fdf7 
Rollup merge of rust-lang#128721 - Brezak:pointee-in-strange-places, r=pnkfelix

Don't allow the `#[pointee]` attribute where it doesn't belong

Error if the `#[pointee]` attribute is applied to anything but generic type parameters.

Closes rust-lang#128485
Related to rust-lang#123430
@luca3s luca3s mentioned this issue Oct 11, 2024
Open
This was referenced Dec 2, 2024
Merged
Open
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Dec 4, 2024
@matthiaskrgr
Rollup merge of rust-lang#133774 - dingxiangfei2009:translatable-coer…
4b2d68d 
…ce-pointee-errors, r=jieyouxu

Make CoercePointee errors translatable

Tracked by rust-lang#123430

Just in case that a translatable error message would become a blocker to stabilization, this PR switches over to fluent error messages, which also slightly improve the wordings and use more accurate span information.

cc `@Darksonn` `@traviscross`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Dec 4, 2024
@rust-timer
Unrolled build for rust-lang#133774
12853ff 
Rollup merge of rust-lang#133774 - dingxiangfei2009:translatable-coerce-pointee-errors, r=jieyouxu

Make CoercePointee errors translatable

Tracked by rust-lang#123430

Just in case that a translatable error message would become a blocker to stabilization, this PR switches over to fluent error messages, which also slightly improve the wordings and use more accurate span information.

cc `@Darksonn` `@traviscross`
@workingjubilee workingjubilee changed the title Tracking issue for RFC 3621: derive(SmartPtr) Tracking issue for RFC 3621: derive(CoercePointee) Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
B-experimental Blocker: In-tree experiment; RFC pending, not yet approved or unneeded. C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC F-derive_coerce_pointee Feature: RFC 3621's oft-renamed implementation S-tracking-impl-incomplete Status: The implementation is incomplete. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@traviscross @Kixunil @fmease