Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: no rules expected the token . #121611

Closed
Mark-Simulacrum opened this issue Feb 25, 2024 · 4 comments
Closed

regression: no rules expected the token . #121611

Mark-Simulacrum opened this issue Feb 25, 2024 · 4 comments
Labels
A-parser Area: The parsing of Rust source code to an AST regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

https://crater-reports.s3.amazonaws.com/beta-1.77-3/beta-2024-02-18/reg/gen-nested-iter-yield-0.1.3/log.txt

[INFO] [stdout] error: no rules expected the token `.`
[INFO] [stdout]   --> tests/tests.rs:45:13
[INFO] [stdout]    |
[INFO] [stdout] 45 |             nested_iter_yield!(input_vector.iter(), 2, .clone())
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no rules expected this token in macro call
[INFO] [stdout]    |
[INFO] [stdout]    = note: while trying to match end of macro
[INFO] [stdout]    = note: this error originates in the macro `nested_iter_yield` (in Nightly builds, run with -Z macro-backtrace for more info)
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] error: no rules expected the token `.`
[INFO] [stdout]   --> tests/tests.rs:67:13
[INFO] [stdout]    |
[INFO] [stdout] 67 |             nested_iter_yield!(input_vector.iter(), 2, .clone(), ::)
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no rules expected this token in macro call
[INFO] [stdout]    |
[INFO] [stdout]    = note: while trying to match end of macro
[INFO] [stdout]    = note: this error originates in the macro `nested_iter_yield` (in Nightly builds, run with -Z macro-backtrace for more info)
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Feb 25, 2024
@Mark-Simulacrum Mark-Simulacrum added this to the 1.77.0 milestone Feb 25, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 25, 2024
@compiler-errors
Copy link
Member

compiler-errors commented Feb 26, 2024

More regressions from macro spacing -- #120227

cc @nnethercote @petrochenkov


searched nightlies: from nightly-2024-01-01 to nightly-2024-02-26
regressed nightly: nightly-2024-02-01
searched commit range: cb4d9a1...11f32b7
regressed commit: 80deabd

bisected with cargo-bisect-rustc v0.6.7

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc --start=2024-01-01 -- test

@nnethercote
Copy link
Contributor

gen-nested-iter-yield-0.1.3 was one of the expected cases failure cases for #120227, due to relying on the exact whitespace used by pretty-printing: see this comment summarizing the crater run. And this comment mentions relnotes.

@apiraino
Copy link
Contributor

WG-prioritization removing prioritization label (Zulip discussion).

If I understand, this breakage was abundantly discussed and approved, so there is no further actionable for us (besides the relnotes). Thanks @nnethercote for the thoroughness in #120227

@rustbot label -I-prioritize

@rustbot rustbot removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 26, 2024
@jieyouxu jieyouxu added A-parser Area: The parsing of Rust source code to an AST and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Feb 26, 2024
@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Oct 11, 2024
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 11, 2024
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 12, 2024
@apiraino
Copy link
Contributor

Closing since regression is mentioned in the release notes

@apiraino apiraino closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-parser Area: The parsing of Rust source code to an AST regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants