Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename src/bootstrap/native.rs to llvm.rs #108240

Closed
jyn514 opened this issue Feb 19, 2023 · 3 comments · Fixed by #109418
Closed

Rename src/bootstrap/native.rs to llvm.rs #108240

jyn514 opened this issue Feb 19, 2023 · 3 comments · Fixed by #109418
Assignees
@jkvargas
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@jyn514
Copy link
Member

jyn514 commented Feb 19, 2023 •
edited by rustbot
Loading

The comment at the top of the file says

rust/src/bootstrap/native.rs

Line 1 in ae5473c

//! Compilation of native dependencies like LLVM.
so presumably the logic is that "native" includes C/C++ code that isn't LLVM. But the only C code that's not LLVM is

rust/src/bootstrap/native.rs

Line 899 in ae5473c

pub struct TestHelpers {
I think we should move TestHelpers to test.rs and rename native.rs to llvm.rs to make it easier to find for new contributors.

cc @compiler-errors, I think you asked about where to find this code recently.
@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. labels Feb 19, 2023
@jkvargas jkvargas mentioned this issue Feb 19, 2023
Closed
@jkvargas
Copy link

@rustbot claim

@rohaquinlop
Copy link
Contributor

@rustbot claim

@rustbot rustbot assigned rohaquinlop and unassigned jkvargas Mar 14, 2023
This was referenced Mar 14, 2023
Closed
Merged
@jkvargas jkvargas mentioned this issue Mar 27, 2023
Closed
@jkvargas
Copy link

@rustbot claim

@rustbot rustbot assigned jkvargas and unassigned rohaquinlop Mar 27, 2023
@bors bors closed this as completed in 3917644 Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkvargas jkvargas

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. E-help-wanted Call for participation: Help is requested to fix this issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
3 participants
@jkvargas @jyn514 @rohaquinlop