regression: parameter may not live long enough

[Mark-Simulacrum]

• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/OliverEvans96.payments-engine-example/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/broxus.nekoton-wasm/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/lukechu10.maple-trunk-gitpod-template/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/sycamore-rs.sycamore-rocket-template/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/sycamore-rs.sycamore-rocket/log.txt
• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/kyrosle.webcam-live/log.txt

[INFO] [stdout] error[E0309]: the parameter type `T` may not live long enough
[INFO] [stdout]    --> src/validate.rs:245:13
[INFO] [stdout]     |
[INFO] [stdout] 245 |             validate_post_dispute_for_existing_tx(post, disputed_tx, accounts, disputes)
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ...so that the type `T` will meet its required lifetime bounds
[INFO] [stdout]     |
[INFO] [stdout] help: consider adding an explicit lifetime bound...
[INFO] [stdout]     |
[INFO] [stdout] 228 | pub fn validate_post_dispute<'a, 't, 'd, T: PostDispute + 't>(
[INFO] [stdout]     |                                                         ++++
[INFO] [stdout] 
[INFO] [stdout] 

[apiraino]

I've bisected the first and last crate in the list, both point to commit f5193a9 -> #95474 cc @oli-obk

bisected with cargo-bisect-rustc v0.6.0

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc 2022-03-01 --preserve 

[apiraino]

since they're regressions on existing crates, let's label them as P-critical out of caution to signal that we want them checked before the next stable

@rustbot label -I-prioritize +P-critical

[Mark-Simulacrum]

It doesn't look like they were noted in the PR run (unless I'm missing the relevant comment). I think given the volume of breakage it likely makes sense to move ahead, but it would be great to put up PRs to these crates.

[oli-obk]

• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/OliverEvans96.payments-engine-example/log.txt
  • already had a fix PR Forward compat change to prep for breakage from a soundness fix OliverEvans96/payments-engine-example#1
• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/lukechu10.maple-trunk-gitpod-template/log.txt
  • sycamore failure
• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/sycamore-rs.sycamore-rocket-template/log.txt
  • fix PR already landed
• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/sycamore-rs.sycamore-rocket/log.txt
  • sycamore failure
• https://crater-reports.s3.amazonaws.com/beta-1.66-1.2/beta-2022-11-01/gh/kyrosle.webcam-live/log.txt
  • sycamore failure

[apiraino]

ah nice, thanks @oli-obk for the additional context :)

@rustbot label -P-critical

[Mark-Simulacrum]

This is known breakage, not release blocking, and is mentioned in release notes (https://github.com/rust-lang/rust/pull/104405/files#diff-4a00447b47c36ebd3ded77321deff288e424f4605496ee1199fc9953a20f4473R77). Resolving.