rustc_resolve: remove unneeded returns

yotamofek · yotamofek · commit a93616acf311 · 2025-01-21T13:34:12.000Z
diff --git a/compiler/rustc_resolve/src/diagnostics.rs b/compiler/rustc_resolve/src/diagnostics.rs
@@ -3042,7 +3042,6 @@ impl<'tcx> visit::Visitor<'tcx> for UsePlacementFinder {
                 self.first_legal_span = Some(inject);
             }
             self.first_use_span = search_for_any_use_in_items(&c.items);
-            return;
         } else {
             visit::walk_crate(self, c);
         }
@@ -3056,7 +3055,6 @@ impl<'tcx> visit::Visitor<'tcx> for UsePlacementFinder {
                     self.first_legal_span = Some(inject);
                 }
                 self.first_use_span = search_for_any_use_in_items(items);
-                return;
             }
         } else {
             visit::walk_item(self, item);

Original file line number	Diff line number	Diff line change
`@@ -3042,7 +3042,6 @@ impl<'tcx> visit::Visitor<'tcx> for UsePlacementFinder {`
`3042`	`3042`	`self.first_legal_span = Some(inject);`
`3043`	`3043`	`}`
`3044`	`3044`	`self.first_use_span = search_for_any_use_in_items(&c.items);`
`3045`		`- return;`
`3046`	`3045`	`} else {`
`3047`	`3046`	`visit::walk_crate(self, c);`
`3048`	`3047`	`}`
`@@ -3056,7 +3055,6 @@ impl<'tcx> visit::Visitor<'tcx> for UsePlacementFinder {`
`3056`	`3055`	`self.first_legal_span = Some(inject);`
`3057`	`3056`	`}`
`3058`	`3057`	`self.first_use_span = search_for_any_use_in_items(items);`
`3059`		`- return;`
`3060`	`3058`	`}`
`3061`	`3059`	`} else {`
`3062`	`3060`	`visit::walk_item(self, item);`