fix: Address minor FIXME

Veykril · Veykril · commit 99f00927cc1d · 2025-04-28T11:55:26.000+02:00
diff --git a/src/tools/rust-analyzer/crates/hir-def/src/item_scope.rs b/src/tools/rust-analyzer/crates/hir-def/src/item_scope.rs
@@ -167,7 +167,7 @@ pub struct ItemScope {
     // the resolutions of the imports of this scope
     use_imports_types: FxHashMap<ImportOrExternCrate, ImportOrDef>,
     use_imports_values: FxHashMap<ImportOrGlob, ImportOrDef>,
-    use_imports_macros: FxHashMap<ImportOrGlob, ImportOrDef>,
+    use_imports_macros: FxHashMap<ImportOrExternCrate, ImportOrDef>,
 
     use_decls: Vec<UseId>,
     extern_crate_decls: Vec<ExternCrateId>,
@@ -242,17 +242,17 @@ impl ItemScope {
         self.types.iter().map(|(n, &i)| (n, i))
     }
 
-    pub fn macros(&self) -> impl Iterator<Item = (&Name, Item<MacroId, ImportOrGlob>)> + '_ {
+    pub fn macros(&self) -> impl Iterator<Item = (&Name, Item<MacroId, ImportOrExternCrate>)> + '_ {
         self.macros.iter().map(|(n, &i)| (n, i))
     }
 
     pub fn imports(&self) -> impl Iterator<Item = ImportId> + '_ {
         self.use_imports_types
             .keys()
             .copied()
+            .chain(self.use_imports_macros.keys().copied())
             .filter_map(ImportOrExternCrate::import_or_glob)
             .chain(self.use_imports_values.keys().copied())
-            .chain(self.use_imports_macros.keys().copied())
             .filter_map(ImportOrGlob::into_import)
             .sorted()
             .dedup()
@@ -263,7 +263,7 @@ impl ItemScope {
 
         let mut def_map;
         let mut scope = self;
-        while let Some(&m) = scope.use_imports_macros.get(&ImportOrGlob::Import(import)) {
+        while let Some(&m) = scope.use_imports_macros.get(&ImportOrExternCrate::Import(import)) {
             match m {
                 ImportOrDef::Import(i) => {
                     let module_id = i.use_.lookup(db).container;
@@ -682,7 +682,6 @@ impl ItemScope {
                         }
                         _ => _ = glob_imports.macros.remove(&lookup),
                     }
-                    let import = import.and_then(ImportOrExternCrate::import_or_glob);
                     let prev = std::mem::replace(&mut fld.import, import);
                     if let Some(import) = import {
                         self.use_imports_macros.insert(
@@ -698,7 +697,6 @@ impl ItemScope {
                 {
                     if glob_imports.macros.remove(&lookup) {
                         cov_mark::hit!(import_shadowed);
-                        let import = import.and_then(ImportOrExternCrate::import_or_glob);
                         let prev = std::mem::replace(&mut fld.import, import);
                         if let Some(import) = import {
                             self.use_imports_macros.insert(
@@ -783,8 +781,9 @@ impl ItemScope {
             if let Some(Item { import, .. }) = def.macros {
                 buf.push_str(" m");
                 match import {
-                    Some(ImportOrGlob::Import(_)) => buf.push('i'),
-                    Some(ImportOrGlob::Glob(_)) => buf.push('g'),
+                    Some(ImportOrExternCrate::Import(_)) => buf.push('i'),
+                    Some(ImportOrExternCrate::Glob(_)) => buf.push('g'),
+                    Some(ImportOrExternCrate::ExternCrate(_)) => buf.push('e'),
                     None => (),
                 }
             }
@@ -893,9 +892,7 @@ impl PerNs {
             ModuleDefId::TraitAliasId(_) => PerNs::types(def, v, import),
             ModuleDefId::TypeAliasId(_) => PerNs::types(def, v, import),
             ModuleDefId::BuiltinType(_) => PerNs::types(def, v, import),
-            ModuleDefId::MacroId(mac) => {
-                PerNs::macros(mac, v, import.and_then(ImportOrExternCrate::import_or_glob))
-            }
+            ModuleDefId::MacroId(mac) => PerNs::macros(mac, v, import),
         }
     }
 }
diff --git a/src/tools/rust-analyzer/crates/hir-def/src/nameres/path_resolution.rs b/src/tools/rust-analyzer/crates/hir-def/src/nameres/path_resolution.rs
@@ -673,12 +673,11 @@ impl DefMap {
     }
 
     fn resolve_in_macro_use_prelude(&self, name: &Name) -> PerNs {
-        self.macro_use_prelude.get(name).map_or(PerNs::none(), |&(it, _extern_crate)| {
+        self.macro_use_prelude.get(name).map_or(PerNs::none(), |&(it, extern_crate)| {
             PerNs::macros(
                 it,
                 Visibility::Public,
-                // FIXME?
-                None, // extern_crate.map(ImportOrExternCrate::ExternCrate),
+                extern_crate.map(ImportOrExternCrate::ExternCrate),
             )
         })
     }
diff --git a/src/tools/rust-analyzer/crates/hir-def/src/per_ns.rs b/src/tools/rust-analyzer/crates/hir-def/src/per_ns.rs
@@ -37,7 +37,8 @@ pub struct Item<Def, Import = ImportId> {
 
 pub type TypesItem = Item<ModuleDefId, ImportOrExternCrate>;
 pub type ValuesItem = Item<ModuleDefId, ImportOrGlob>;
-pub type MacrosItem = Item<MacroId, ImportOrGlob>;
+// May be Externcrate for `[macro_use]`'d macros
+pub type MacrosItem = Item<MacroId, ImportOrExternCrate>;
 
 #[derive(Clone, Copy, Debug, Default, Eq, Hash, PartialEq)]
 pub struct PerNs {
@@ -84,7 +85,7 @@ impl PerNs {
         }
     }
 
-    pub fn macros(def: MacroId, vis: Visibility, import: Option<ImportOrGlob>) -> PerNs {
+    pub fn macros(def: MacroId, vis: Visibility, import: Option<ImportOrExternCrate>) -> PerNs {
         PerNs { types: None, values: None, macros: Some(Item { def, vis, import }) }
     }
 
@@ -116,7 +117,7 @@ impl PerNs {
         self.macros.map(|it| it.def)
     }
 
-    pub fn take_macros_import(self) -> Option<(MacroId, Option<ImportOrGlob>)> {
+    pub fn take_macros_import(self) -> Option<(MacroId, Option<ImportOrExternCrate>)> {
         self.macros.map(|it| (it.def, it.import))
     }
 
@@ -158,9 +159,6 @@ impl PerNs {
                 self.values
                     .map(|it| (ItemInNs::Values(it.def), it.import.map(ImportOrExternCrate::from))),
             )
-            .chain(
-                self.macros
-                    .map(|it| (ItemInNs::Macros(it.def), it.import.map(ImportOrExternCrate::from))),
-            )
+            .chain(self.macros.map(|it| (ItemInNs::Macros(it.def), it.import)))
     }
 }
diff --git a/src/tools/rust-analyzer/crates/hir-def/src/resolver.rs b/src/tools/rust-analyzer/crates/hir-def/src/resolver.rs
@@ -493,7 +493,7 @@ impl Resolver {
         db: &dyn DefDatabase,
         path: &ModPath,
         expected_macro_kind: Option<MacroSubNs>,
-    ) -> Option<(MacroId, Option<ImportOrGlob>)> {
+    ) -> Option<(MacroId, Option<ImportOrExternCrate>)> {
         let (item_map, item_local_map, module) = self.item_scope_();
         item_map
             .resolve_path(
diff --git a/src/tools/rust-analyzer/crates/hir/src/symbols.rs b/src/tools/rust-analyzer/crates/hir/src/symbols.rs
@@ -263,8 +263,9 @@ impl<'a> SymbolCollector<'a> {
         for (name, Item { def, vis, import }) in scope.macros() {
             if let Some(i) = import {
                 match i {
-                    ImportOrGlob::Import(i) => push_import(self, i, name, def.into(), vis),
-                    ImportOrGlob::Glob(_) => (),
+                    ImportOrExternCrate::Import(i) => push_import(self, i, name, def.into(), vis),
+                    ImportOrExternCrate::Glob(_) => (),
+                    ImportOrExternCrate::ExternCrate(_) => (),
                 }
                 continue;
             }

Original file line number	Diff line number	Diff line change
`@@ -673,12 +673,11 @@ impl DefMap {`
`673`	`673`	`}`
`674`	`674`
`675`	`675`	`fn resolve_in_macro_use_prelude(&self, name: &Name) -> PerNs {`
`676`		`- self.macro_use_prelude.get(name).map_or(PerNs::none(), \|&(it, _extern_crate)\| {`
	`676`	`+ self.macro_use_prelude.get(name).map_or(PerNs::none(), \|&(it, extern_crate)\| {`
`677`	`677`	`PerNs::macros(`
`678`	`678`	`it,`
`679`	`679`	`Visibility::Public,`
`680`		`- // FIXME?`
`681`		`- None, // extern_crate.map(ImportOrExternCrate::ExternCrate),`
	`680`	`+ extern_crate.map(ImportOrExternCrate::ExternCrate),`
`682`	`681`	`)`
`683`	`682`	`})`
`684`	`683`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,8 @@ pub struct Item<Def, Import = ImportId> {`
`37`	`37`
`38`	`38`	`pub type TypesItem = Item<ModuleDefId, ImportOrExternCrate>;`
`39`	`39`	`pub type ValuesItem = Item<ModuleDefId, ImportOrGlob>;`
`40`		`-pub type MacrosItem = Item<MacroId, ImportOrGlob>;`
	`40`	+// May be Externcrate for `[macro_use]`'d macros
	`41`	`+pub type MacrosItem = Item<MacroId, ImportOrExternCrate>;`
`41`	`42`
`42`	`43`	`#[derive(Clone, Copy, Debug, Default, Eq, Hash, PartialEq)]`
`43`	`44`	`pub struct PerNs {`
`@@ -84,7 +85,7 @@ impl PerNs {`
`84`	`85`	`}`
`85`	`86`	`}`
`86`	`87`
`87`		`- pub fn macros(def: MacroId, vis: Visibility, import: Option<ImportOrGlob>) -> PerNs {`
	`88`	`+ pub fn macros(def: MacroId, vis: Visibility, import: Option<ImportOrExternCrate>) -> PerNs {`
`88`	`89`	`PerNs { types: None, values: None, macros: Some(Item { def, vis, import }) }`
`89`	`90`	`}`
`90`	`91`
`@@ -116,7 +117,7 @@ impl PerNs {`
`116`	`117`	`self.macros.map(\|it\| it.def)`
`117`	`118`	`}`
`118`	`119`
`119`		`- pub fn take_macros_import(self) -> Option<(MacroId, Option<ImportOrGlob>)> {`
	`120`	`+ pub fn take_macros_import(self) -> Option<(MacroId, Option<ImportOrExternCrate>)> {`
`120`	`121`	`self.macros.map(\|it\| (it.def, it.import))`
`121`	`122`	`}`
`122`	`123`
`@@ -158,9 +159,6 @@ impl PerNs {`
`158`	`159`	`self.values`
`159`	`160`	`.map(\|it\| (ItemInNs::Values(it.def), it.import.map(ImportOrExternCrate::from))),`
`160`	`161`	`)`
`161`		`- .chain(`
`162`		`- self.macros`
`163`		`- .map(\|it\| (ItemInNs::Macros(it.def), it.import.map(ImportOrExternCrate::from))),`
`164`		`- )`
	`162`	`+ .chain(self.macros.map(\|it\| (ItemInNs::Macros(it.def), it.import)))`
`165`	`163`	`}`
`166`	`164`	`}`
Original file line number	Diff line number	Diff line change
`@@ -263,8 +263,9 @@ impl<'a> SymbolCollector<'a> {`
`263`	`263`	`for (name, Item { def, vis, import }) in scope.macros() {`
`264`	`264`	`if let Some(i) = import {`
`265`	`265`	`match i {`
`266`		`- ImportOrGlob::Import(i) => push_import(self, i, name, def.into(), vis),`
`267`		`- ImportOrGlob::Glob(_) => (),`
	`266`	`+ ImportOrExternCrate::Import(i) => push_import(self, i, name, def.into(), vis),`
	`267`	`+ ImportOrExternCrate::Glob(_) => (),`
	`268`	`+ ImportOrExternCrate::ExternCrate(_) => (),`
`268`	`269`	`}`
`269`	`270`	`continue;`
`270`	`271`	`}`