File tree Expand file tree Collapse file tree 1 file changed +4
-4
lines changed Expand file tree Collapse file tree 1 file changed +4
-4
lines changed Original file line number Diff line number Diff line change @@ -174,10 +174,10 @@ fn main() {
174174
175175    // Prevent critical warnings when we're compiling from rust-lang/rust CI, 
176176    // except on MSVC, as the compiler throws warnings that are only reported 
177-     // for this platform. See https://github.com/rust-lang/rust/pull/145031#issuecomment-3162677202 
178-     // FIXME(llvm22): It looks like the specific problem code has been removed  
179-     // in https://github.com/llvm/llvm-project/commit/e8fc808bf8e78a3c80d1f8e293a92677b92366dd,  
180-     // retry msvc once we bump our LLVM version . 
177+     // for this platform. See https://github.com/rust-lang/rust/pull/145031#issuecomment-3162677202.  
178+     // Moreover, LLVM generally guarantees warning-freedom only when building with Clang, as other  
179+     // compilers have too many false positives. This is typically the case for MSVC, which throws  
180+     // many false-positive warnings. We keep it excluded, for these reasons . 
181181    if  std:: env:: var_os ( "CI" ) . is_some ( )  && !target. contains ( "msvc" )  { 
182182        cfg. warnings_into_errors ( true ) ; 
183183    } 
 
 
   
 
     
   
   
          
    
    
     
    
      
     
     
    You can’t perform that action at this time.
  
 
    
  
    
      
        
     
       
      
     
   
 
    
    
  
 
  
 
     
    
0 commit comments