name the variant better

Author: iximeow

compiler/rustc_attr_parsing/src/attributes/codegen_attrs.rs

@@ -370,7 +370,7 @@ impl<S: Stage> NoArgsAttributeParser<S> for NoMangleParser {
 pub(crate) struct UsedParser {
     first_compiler: Option<Span>,
     first_linker: Option<Span>,
-    first_generic: Option<Span>,
+    first_default: Option<Span>,
 }
 
 // A custom `AttributeParser` is used rather than a Simple attribute parser because
@@ -383,7 +383,7 @@ impl<S: Stage> AttributeParser<S> for UsedParser {
         template!(Word, List: &["compiler", "linker"]),
         |group: &mut Self, cx, args| {
             let used_by = match args {
-                ArgParser::NoArgs => UsedBy::Any,
+                ArgParser::NoArgs => UsedBy::Default,
                 ArgParser::List(list) => {
                     let Some(l) = list.single() else {
                         cx.expected_single_argument(list.span);
@@ -432,18 +432,18 @@ impl<S: Stage> AttributeParser<S> for UsedParser {
             let target = match used_by {
                 UsedBy::Compiler => &mut group.first_compiler,
                 UsedBy::Linker => {
-                    if let Some(prev) = group.first_generic {
+                    if let Some(prev) = group.first_default {
                         cx.warn_unused_duplicate(prev, attr_span);
                         return;
                     }
                     &mut group.first_linker
                 }
-                UsedBy::Any => {
+                UsedBy::Default => {
                     if let Some(prev) = group.first_linker {
                         cx.warn_unused_duplicate(prev, attr_span);
                         return;
                     }
-                    &mut group.first_generic
+                    &mut group.first_default
                 }
             };
 
@@ -460,10 +460,10 @@ impl<S: Stage> AttributeParser<S> for UsedParser {
     fn finalize(self, _cx: &FinalizeContext<'_, '_, S>) -> Option<AttributeKind> {
         // If a specific form of `used` is specified, it takes precedence over generic `#[used]`.
         // If both `linker` and `compiler` are specified, use `linker`.
-        Some(match (self.first_compiler, self.first_linker, self.first_generic) {
+        Some(match (self.first_compiler, self.first_linker, self.first_default) {
             (_, Some(span), _) => AttributeKind::Used { used_by: UsedBy::Linker, span },
             (Some(span), _, _) => AttributeKind::Used { used_by: UsedBy::Compiler, span },
-            (_, _, Some(span)) => AttributeKind::Used { used_by: UsedBy::Any, span },
+            (_, _, Some(span)) => AttributeKind::Used { used_by: UsedBy::Default, span },
             (None, None, None) => return None,
         })
     }

compiler/rustc_codegen_ssa/src/codegen_attrs.rs

@@ -263,7 +263,7 @@ fn process_builtin_attrs(
                 AttributeKind::Used { used_by, .. } => match used_by {
                     UsedBy::Compiler => codegen_fn_attrs.flags |= CodegenFnAttrFlags::USED_COMPILER,
                     UsedBy::Linker => codegen_fn_attrs.flags |= CodegenFnAttrFlags::USED_LINKER,
-                    UsedBy::Any => {
+                    UsedBy::Default => {
                         let used_form = if tcx.sess.target.os == "illumos" {
                             // illumos' `ld` doesn't support a section header that would represent
                             // `#[used(linker)]`, see

compiler/rustc_hir/src/attrs/data_structures.rs

@@ -152,7 +152,7 @@ impl Deprecation {
 #[derive(Encodable, Decodable, Copy, Clone, Debug, PartialEq, Eq, Hash)]
 #[derive(HashStable_Generic, PrintAttribute)]
 pub enum UsedBy {
-    Any,
+    Default,
     Compiler,
     Linker,
 }