From 44bc150487f9b3dea98548df2e8e08943ea0724b Mon Sep 17 00:00:00 2001 From: Camille GILLOT Date: Sat, 2 Apr 2022 15:27:59 +0200 Subject: [PATCH] Mark crate_inherent_impls as eval_always. This is global query, so it will probably be invalidated anyway. This was creating a compound dependency from any typeck to any hir_owner: typeck -> incoherent_impls -> crate_incoherent_impls -> crate_inherent_impls -> hir_owner. This dependency was (incorrectly?) flagged by the ui/dep-graph tests as problematic. --- compiler/rustc_middle/src/query/mod.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/compiler/rustc_middle/src/query/mod.rs b/compiler/rustc_middle/src/query/mod.rs index 2493b0de6f52e..4c290ecf731ac 100644 --- a/compiler/rustc_middle/src/query/mod.rs +++ b/compiler/rustc_middle/src/query/mod.rs @@ -869,6 +869,7 @@ rustc_queries! { /// Not meant to be used directly outside of coherence. query crate_inherent_impls(k: ()) -> CrateInherentImpls { storage(ArenaCacheSelector<'tcx>) + eval_always desc { "all inherent impls defined in crate" } }